From: William Wu <william.wu@rock-chips.com>
To: Felipe Balbi <balbi@kernel.org>,
gregkh@linuxfoundation.org, heiko@sntech.de
Cc: briannorris@google.com, dianders@google.com,
kever.yang@rock-chips.com, huangtao@rock-chips.com,
frank.wang@rock-chips.com, eddie.cai@rock-chips.com,
John.Youn@synopsys.com, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: dwc3: add DWC3_GUCTL1 reg for debug
Date: Mon, 09 May 2016 21:16:27 +0800 [thread overview]
Message-ID: <57308DAB.3020401@rock-chips.com> (raw)
In-Reply-To: <87bn4f1lfi.fsf@intel.com>
On 05/09/2016 08:10 PM, Felipe Balbi wrote:
> William Wu <william.wu@rock-chips.com> writes:
Thanks Felipe Balbi and Greg KH. I'm really sorry that I forgot to
add changelog.
>> Signed-off-by: William Wu <william.wu@rock-chips.com>
> no changelog = no commit, sorry. Why do you want to dump GUCTL1?
Because GUCTL1 can be written by user. For rockchip platform,
we set GUCTL1.DEV_FORCE_20_CLK_FOR_30_CLK(bit26) to 1 in
bootrom(used for usb2.0 device only),
and after kernel boot, I want to check whether this bit can be
reset to default 0 after core reset.
Dump GUCTL1 reg from debugfs is more convenient for me.
>
>> ---
>> drivers/usb/dwc3/core.h | 1 +
>> drivers/usb/dwc3/debugfs.c | 1 +
>> 2 files changed, 2 insertions(+)
>>
>> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
>> index e15e307..f268869 100644
>> --- a/drivers/usb/dwc3/core.h
>> +++ b/drivers/usb/dwc3/core.h
>> @@ -86,6 +86,7 @@
>> #define DWC3_GCTL 0xc110
>> #define DWC3_GEVTEN 0xc114
>> #define DWC3_GSTS 0xc118
>> +#define DWC3_GUCTL1 0xc11c
>> #define DWC3_GSNPSID 0xc120
>> #define DWC3_GGPIO 0xc124
>> #define DWC3_GUID 0xc128
>> diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c
>> index b1dd3c6..f3c9f44 100644
>> --- a/drivers/usb/dwc3/debugfs.c
>> +++ b/drivers/usb/dwc3/debugfs.c
>> @@ -47,6 +47,7 @@ static const struct debugfs_reg32 dwc3_regs[] = {
>> dump_register(GCTL),
>> dump_register(GEVTEN),
>> dump_register(GSTS),
>> + dump_register(GUCTL1),
>> dump_register(GSNPSID),
>> dump_register(GGPIO),
>> dump_register(GUID),
>> --
>> 1.9.1
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-05-09 13:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-09 12:00 [PATCH] usb: dwc3: add DWC3_GUCTL1 reg for debug William Wu
2016-05-09 12:04 ` Greg KH
2016-05-09 12:10 ` Felipe Balbi
2016-05-09 13:16 ` William Wu [this message]
2016-05-09 13:35 ` Felipe Balbi
-- strict thread matches above, loose matches on Subject: below --
2016-05-13 10:05 William Wu
2016-05-13 10:07 ` William Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57308DAB.3020401@rock-chips.com \
--to=william.wu@rock-chips.com \
--cc=John.Youn@synopsys.com \
--cc=balbi@kernel.org \
--cc=briannorris@google.com \
--cc=dianders@google.com \
--cc=eddie.cai@rock-chips.com \
--cc=frank.wang@rock-chips.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=kever.yang@rock-chips.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox