From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753726AbcEINWO (ORCPT ); Mon, 9 May 2016 09:22:14 -0400 Received: from regular2.263xmail.com ([211.157.152.5]:45566 "EHLO regular2.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752828AbcEINWM (ORCPT ); Mon, 9 May 2016 09:22:12 -0400 X-Greylist: delayed 313 seconds by postgrey-1.27 at vger.kernel.org; Mon, 09 May 2016 09:22:10 EDT X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-KSVirus-check: 0 X-RL-SENDER: wulf@rock-chips.com X-FST-TO: balbi@kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: wulf@rock-chips.com X-UNIQUE-TAG: <3134343ef2472cc3a357a4b00c69f1dc> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <57308DAB.3020401@rock-chips.com> Date: Mon, 09 May 2016 21:16:27 +0800 From: William Wu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Felipe Balbi , gregkh@linuxfoundation.org, heiko@sntech.de CC: briannorris@google.com, dianders@google.com, kever.yang@rock-chips.com, huangtao@rock-chips.com, frank.wang@rock-chips.com, eddie.cai@rock-chips.com, John.Youn@synopsys.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH] usb: dwc3: add DWC3_GUCTL1 reg for debug References: <1462795205-11334-1-git-send-email-william.wu@rock-chips.com> <87bn4f1lfi.fsf@intel.com> In-Reply-To: <87bn4f1lfi.fsf@intel.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/09/2016 08:10 PM, Felipe Balbi wrote: > William Wu writes: Thanks Felipe Balbi and Greg KH. I'm really sorry that I forgot to add changelog. >> Signed-off-by: William Wu > no changelog = no commit, sorry. Why do you want to dump GUCTL1? Because GUCTL1 can be written by user. For rockchip platform, we set GUCTL1.DEV_FORCE_20_CLK_FOR_30_CLK(bit26) to 1 in bootrom(used for usb2.0 device only), and after kernel boot, I want to check whether this bit can be reset to default 0 after core reset. Dump GUCTL1 reg from debugfs is more convenient for me. > >> --- >> drivers/usb/dwc3/core.h | 1 + >> drivers/usb/dwc3/debugfs.c | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h >> index e15e307..f268869 100644 >> --- a/drivers/usb/dwc3/core.h >> +++ b/drivers/usb/dwc3/core.h >> @@ -86,6 +86,7 @@ >> #define DWC3_GCTL 0xc110 >> #define DWC3_GEVTEN 0xc114 >> #define DWC3_GSTS 0xc118 >> +#define DWC3_GUCTL1 0xc11c >> #define DWC3_GSNPSID 0xc120 >> #define DWC3_GGPIO 0xc124 >> #define DWC3_GUID 0xc128 >> diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c >> index b1dd3c6..f3c9f44 100644 >> --- a/drivers/usb/dwc3/debugfs.c >> +++ b/drivers/usb/dwc3/debugfs.c >> @@ -47,6 +47,7 @@ static const struct debugfs_reg32 dwc3_regs[] = { >> dump_register(GCTL), >> dump_register(GEVTEN), >> dump_register(GSTS), >> + dump_register(GUCTL1), >> dump_register(GSNPSID), >> dump_register(GGPIO), >> dump_register(GUID), >> -- >> 1.9.1 >> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-usb" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html