From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753427AbcEINiQ (ORCPT ); Mon, 9 May 2016 09:38:16 -0400 Received: from mx2.suse.de ([195.135.220.15]:39547 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753271AbcEINiH (ORCPT ); Mon, 9 May 2016 09:38:07 -0400 Subject: Re: [PATCH] xen/balloon: Fix declared-but-not-defined warning To: Ross Lagerwall , xen-devel@lists.xenproject.org References: <1462800589-20329-1-git-send-email-ross.lagerwall@citrix.com> Cc: Boris Ostrovsky , David Vrabel , linux-kernel@vger.kernel.org, pebolle@tiscali.nl, geert@linux-m68k.org From: Juergen Gross Message-ID: <573092BA.4000401@suse.com> Date: Mon, 9 May 2016 15:38:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 In-Reply-To: <1462800589-20329-1-git-send-email-ross.lagerwall@citrix.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/05/16 15:29, Ross Lagerwall wrote: > Fix a declared-but-not-defined warning when building with > XEN_BALLOON_MEMORY_HOTPLUG=n. This fixes a regression introduced by > commit dfd74a1edfab > ("xen/balloon: Fix crash when ballooning on x86 32 bit PAE"). > > Signed-off-by: Ross Lagerwall > --- > drivers/xen/balloon.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c > index d46839f..0e57906 100644 > --- a/drivers/xen/balloon.c > +++ b/drivers/xen/balloon.c > @@ -151,8 +151,6 @@ static DECLARE_WAIT_QUEUE_HEAD(balloon_wq); > static void balloon_process(struct work_struct *work); > static DECLARE_DELAYED_WORK(balloon_worker, balloon_process); > > -static void release_memory_resource(struct resource *resource); > - > /* When ballooning out (allocating memory to return to Xen) we don't really > want the kernel to try too hard since that can trigger the oom killer. */ > #define GFP_BALLOON \ > @@ -248,6 +246,8 @@ static enum bp_state update_schedule(enum bp_state state) > } > > #ifdef CONFIG_XEN_BALLOON_MEMORY_HOTPLUG > +static void release_memory_resource(struct resource *resource); > + I'd rather move release_memory_resource() here instead of adding the prototype. Juergen > static struct resource *additional_memory_resource(phys_addr_t size) > { > struct resource *res; >