From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751833AbcEIR6f (ORCPT ); Mon, 9 May 2016 13:58:35 -0400 Received: from mail-ig0-f169.google.com ([209.85.213.169]:37793 "EHLO mail-ig0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750919AbcEIR6d (ORCPT ); Mon, 9 May 2016 13:58:33 -0400 Subject: Re: [PATCH BUGFIX] block: add missing group association in bio_split To: Mark Brown , Paolo References: <1462567512-3007-1-git-send-email-paolo.valente@linaro.org> <5730A108.1000703@linaro.org> <20160509145647.GB3458@sirena.org.uk> Cc: Jeff Moyer , Tejun Heo , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, ulf.hansson@linaro.org, linus.walleij@linaro.org, stable@vger.kernel.org From: Jens Axboe Message-ID: <5730CFC5.80201@kernel.dk> Date: Mon, 9 May 2016 11:58:29 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20160509145647.GB3458@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/09/2016 08:56 AM, Mark Brown wrote: > On Mon, May 09, 2016 at 04:39:04PM +0200, Paolo wrote: >> Il 09/05/2016 16:35, Jeff Moyer ha scritto: > >>> Gah, I see that the bi_css member is only present for CONFIG_BLK_CGROUP. >>> I guess we'll have to live with the ifdef. > >> We have already tried to remove it, but it seems it would require other >> major changes. > > It probably should get fixed, but separately to the bug fix. It's a minor tweak, might as well submit them together. Because if you don't, it has a tendency to be forgotten once the original issue is resolved. -- Jens Axboe