From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753361AbcEJBrM (ORCPT <rfc822;w@1wt.eu>);
	Mon, 9 May 2016 21:47:12 -0400
Received: from szxga03-in.huawei.com ([119.145.14.66]:28858 "EHLO
	szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752446AbcEJBrL (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 9 May 2016 21:47:11 -0400
Subject: Re: [PATCH 1/8] perf tools: Omit DWARF judgement when recording dwarf
 callchain
To: Arnaldo Carvalho de Melo <acme@kernel.org>, Jiri Olsa <jolsa@redhat.com>
References: <1462525154-125656-1-git-send-email-hekuang@huawei.com>
 <1462525154-125656-2-git-send-email-hekuang@huawei.com>
 <20160507180346.GB19977@krava> <20160509161649.GA3903@kernel.org>
CC: <peterz@infradead.org>, <mingo@redhat.com>,
        <alexander.shishkin@linux.intel.com>, <wangnan0@huawei.com>,
        <jpoimboe@redhat.com>, <ak@linux.intel.com>, <eranian@google.com>,
        <namhyung@kernel.org>, <adrian.hunter@intel.com>,
        <sukadev@linux.vnet.ibm.com>, <masami.hiramatsu.pt@hitachi.com>,
        <tumanova@linux.vnet.ibm.com>, <kan.liang@intel.com>,
        <penberg@kernel.org>, <dsahern@gmail.com>,
        <linux-kernel@vger.kernel.org>
From: Hekuang <hekuang@huawei.com>
Message-ID: <57313D10.5040808@huawei.com>
Date: Tue, 10 May 2016 09:44:48 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <20160509161649.GA3903@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.110.55.166]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A020202.57313D21.0017,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-05-26 15:14:31,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: b7a04ba9f0df120084870c99f386bee1
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

ok

在 2016/5/10 0:16, Arnaldo Carvalho de Melo 写道:
> Em Sat, May 07, 2016 at 08:03:46PM +0200, Jiri Olsa escreveu:
>> On Fri, May 06, 2016 at 08:59:07AM +0000, He Kuang wrote:
>>> There's no need for dwarf support when perf recording with callchain.
>>>
>>> Signed-off-by: He Kuang <hekuang@huawei.com>
>> Acked-by: Jiri Olsa <jolsa@kernel.org>
> Ok, due to your Ack I went on to read the code and indeed, with this
> changeset description:
>
> "There is no need to check for DWARF unwinding support when using the
> 'dwarf' callchain record method, as this will only ask the kernel to
> collect stack dumps for later DWARF CFI processing, which can be done
> in another machine, where the support for DWARF unwinding need to be
> present."
>
> Thanks,
>
> - Arnaldo
>   
>> thanks,
>> jirka
>>
>>> ---
>>>   tools/perf/util/util.c | 2 --
>>>   1 file changed, 2 deletions(-)
>>>
>>> diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c
>>> index b7766c5..e5ebfd4 100644
>>> --- a/tools/perf/util/util.c
>>> +++ b/tools/perf/util/util.c
>>> @@ -471,7 +471,6 @@ int parse_callchain_record(const char *arg, struct callchain_param *param)
>>>   				       "needed for --call-graph fp\n");
>>>   			break;
>>>   
>>> -#ifdef HAVE_DWARF_UNWIND_SUPPORT
>>>   		/* Dwarf style */
>>>   		} else if (!strncmp(name, "dwarf", sizeof("dwarf"))) {
>>>   			const unsigned long default_stack_dump_size = 8192;
>>> @@ -487,7 +486,6 @@ int parse_callchain_record(const char *arg, struct callchain_param *param)
>>>   				ret = get_stack_size(tok, &size);
>>>   				param->dump_size = size;
>>>   			}
>>> -#endif /* HAVE_DWARF_UNWIND_SUPPORT */
>>>   		} else if (!strncmp(name, "lbr", sizeof("lbr"))) {
>>>   			if (!strtok_r(NULL, ",", &saveptr)) {
>>>   				param->record_mode = CALLCHAIN_LBR;
>>> -- 
>>> 1.8.5.2
>>>