From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752034AbcEJFfz (ORCPT <rfc822;w@1wt.eu>);
	Tue, 10 May 2016 01:35:55 -0400
Received: from mailout3.w1.samsung.com ([210.118.77.13]:58767 "EHLO
	mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751348AbcEJFfx (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 10 May 2016 01:35:53 -0400
X-AuditID: cbfec7f4-f796c6d000001486-12-57317335ccb5
Subject: Re: [PATCH v2 22/22] ARM: dts: exynos: Add initial support for Odroid
 XU board
To: Javier Martinez Canillas <javier@osg.samsung.com>,
        Kukjin Kim <kgene@kernel.org>,
        Krzysztof Kozlowski <k.kozlowski@samsung.com>,
        Sylwester Nawrocki <s.nawrocki@samsung.com>,
        Tomasz Figa <tomasz.figa@gmail.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@codeaurora.org>,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
References: <1462734367-5619-1-git-send-email-krzk@kernel.org>
 <1462734367-5619-23-git-send-email-krzk@kernel.org>
 <cbcb5657-8825-83cf-688f-d565ac7ecbab@osg.samsung.com>
From: Krzysztof Kozlowski <krzk@kernel.org>
Message-id: <57317333.5010309@kernel.org>
Date: Tue, 10 May 2016 07:35:47 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-version: 1.0
In-reply-to: <cbcb5657-8825-83cf-688f-d565ac7ecbab@osg.samsung.com>
Content-type: text/plain; charset=windows-1252
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrCLMWRmVeSWpSXmKPExsVy+t/xy7qmxYbhBp1rtSzmHznHavHm7Rom
	i9cvDC36H79mttj0+Bqrxceee6wWl3fNYbOYcX4fk8XFU64Wh9+0s1r8ONPNYrFq1x9GBx6P
	9zda2T0u9/UyeeycdZfdY9OqTjaPzUvqPbb0A3l9W1YxenzeJBfAEcVlk5Kak1mWWqRvl8CV
	MfvDJJaCrRwV7TPfsTcwPmPrYuTkkBAwkTj0cSkjhC0mceHeeqA4F4eQwFJGiVl3njBDOM8Y
	JebOmQ9WJSwQKXFw0x1WkISIwGVmiVn33zBCVK1llHjb9BCon4ODTUBb4t+WYpAGXgFNiQvT
	D4E1swioSqx/cJ0FxBYViJBYve4aM0SNoMSPyffA4pwCzhInf09kARnDLKAncf+iFkiYWUBe
	YvOat8wTGPlnIemYhVA1C0nVAkbmVYyiqaXJBcVJ6bmGesWJucWleel6yfm5mxghcfFlB+Pi
	Y1aHGAU4GJV4eHdwGYYLsSaWFVfmHmKU4GBWEuE9UwAU4k1JrKxKLcqPLyrNSS0+xCjNwaIk
	zjt31/sQIYH0xJLU7NTUgtQimCwTB6dUA6P4me0Oq84d6glw/jKl0kSvW1I9Jel6vFV36f07
	J9Kl9kyTT/Y+9f7MqkVBfr9+F6wQuJH6NTPisP7xaJ0vZileWcnrNu4+vdL+1gTrz4wfphwS
	vvr3shHbz5qz6Y+z6tWT9dKXvC840jHnq8rXDdWTpuj1uW+67PZT/EUY+4z5rc0zhX/+/r5C
	iaU4I9FQi7moOBEA+knihocCAAA=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/10/2016 12:02 AM, Javier Martinez Canillas wrote:
> Hello Krzysztof,
> 
> On 05/08/2016 03:06 PM, Krzysztof Kozlowski wrote:
>> The Hardkernel's Odroid XU board was first design with big.LITTLE SoC
>> from Samsung: the Exynos5410. Comparing now to more popular Odroid XU3
>> the differences are:
>> 1. Exynos5410 instead of 5422,
>> 2. DisplayPort,
>> 3. Main PMIC: Maxim 77802 instead of S2MPS11,
>> 4. USB3503+LAN9730 instead of integrated LAN9514,
>> 5. eMMC 4.5 instead of eMMC 5.0,
>>
>> This patch adds initial support for the XU board with working basic
>> functions, eMMC/SD and USB (including attached ethernet adapter).
>>
>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>> ---
> 
> This DTS has some TODO's, FIXME's and commented input supplies. Probably
> this patch should had been an RFC? or you should mention about these in
> the commit message to understand why are there.

I have to clean it up or fix these notes. Actually I was quite surprised
that board worked fine with this basic setup.

Best regards,
Krzysztof