From: William Wu <william.wu@rock-chips.com>
To: Felipe Balbi <balbi@kernel.org>, Doug Anderson <dianders@google.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Heiko Stübner" <heiko@sntech.de>,
"Brian Norris" <briannorris@google.com>,
"Kever Yang" <kever.yang@rock-chips.com>,
"Tao Huang" <huangtao@rock-chips.com>,
frank.wang@rock-chips.com, "Eddie Cai" <eddie.cai@rock-chips.com>,
"John Youn" <John.Youn@synopsys.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH 1/4] usb: dwc3: of-simple: add compatible for rockchip
Date: Tue, 10 May 2016 15:39:49 +0800 [thread overview]
Message-ID: <57319045.9050907@rock-chips.com> (raw)
In-Reply-To: <8737pq8jvi.fsf@linux.intel.com>
Dear Felipe & Doug,
Thanks for your proposal. It's a good idea to sort the list.
I'll fix it next patch version.
On 05/10/2016 03:14 PM, Felipe Balbi wrote:
> Hi,
>
> Doug Anderson <dianders@google.com> writes:
>> William,
>>
>> On Mon, May 9, 2016 at 4:46 AM, William Wu <william.wu@rock-chips.com> wrote:
>>> Signed-off-by: William Wu <william.wu@rock-chips.com>
>>> ---
>>> drivers/usb/dwc3/dwc3-of-simple.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
>>> index 9743353..1f3665b 100644
>>> --- a/drivers/usb/dwc3/dwc3-of-simple.c
>>> +++ b/drivers/usb/dwc3/dwc3-of-simple.c
>>> @@ -162,6 +162,7 @@ static const struct dev_pm_ops dwc3_of_simple_dev_pm_ops = {
>>> static const struct of_device_id of_dwc3_simple_match[] = {
>>> { .compatible = "qcom,dwc3" },
>>> { .compatible = "xlnx,zynqmp-dwc3" },
>>> + { .compatible = "rockchip,dwc3" },
>> It is, of course, up to Felipe. ...but personally I'd prefer that
>> things here be sorted alphabetically. Sorting things in a consistent
>> manner tends to reduce merge conflicts as the list gets longer and
>> also makes it easier to find things.
> I agree, let's keep it sorted :-)
>
next prev parent reply other threads:[~2016-05-10 7:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-09 11:46 [PATCH 0/4] support rockchip dwc3 driver William Wu
2016-05-09 11:46 ` [PATCH 1/4] usb: dwc3: of-simple: add compatible for rockchip William Wu
2016-05-09 15:16 ` Doug Anderson
2016-05-10 7:14 ` Felipe Balbi
2016-05-10 7:39 ` William Wu [this message]
2016-05-10 8:11 ` Felipe Balbi
2016-05-10 8:27 ` William Wu
2016-05-09 19:24 ` Brian Norris
2016-05-10 7:15 ` Felipe Balbi
2016-05-10 8:14 ` William Wu
2016-05-09 11:46 ` [PATCH 2/4] usb: dwc3: add dis_u2_freeclk_exists_quirk William Wu
2016-05-09 11:46 ` [PATCH 3/4] usb: dwc3: make usb2 phy interface configurable in DT William Wu
2016-05-09 12:18 ` Felipe Balbi
2016-05-09 13:28 ` William Wu
2016-05-09 13:32 ` Felipe Balbi
2016-05-09 11:46 ` [PATCH 4/4] usb: dwc3: add dis_del_phy_power_chg_quirk William Wu
2016-05-13 9:24 ` [PATCH v2 0/5] support rockchip dwc3 driver William Wu
2016-05-13 9:24 ` [PATCH v2 1/5] usb: dwc3: of-simple: add compatible for rockchip William Wu
2016-05-13 9:24 ` [PATCH v2 2/5] usb: dwc3: add dis_u2_freeclk_exists_quirk William Wu
2016-05-13 9:24 ` [PATCH v2 3/5] usb: dwc3: add phyif_utmi_quirk William Wu
2016-05-13 9:25 ` [PATCH v2 4/5] usb: dwc3: add dis_del_phy_power_chg_quirk William Wu
2016-05-13 9:30 ` [PATCH v2 0/5] support rockchip dwc3 driver Heiko Stuebner
2016-05-13 9:37 ` Felipe Balbi
2016-05-13 9:48 ` William Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57319045.9050907@rock-chips.com \
--to=william.wu@rock-chips.com \
--cc=John.Youn@synopsys.com \
--cc=balbi@kernel.org \
--cc=briannorris@google.com \
--cc=dianders@google.com \
--cc=eddie.cai@rock-chips.com \
--cc=frank.wang@rock-chips.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=kever.yang@rock-chips.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox