From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751759AbcEJJNG (ORCPT ); Tue, 10 May 2016 05:13:06 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:38836 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751271AbcEJJJ5 (ORCPT ); Tue, 10 May 2016 05:09:57 -0400 Reply-To: nicolas.dichtel@6wind.com Subject: Re: [PATCH net-next v3] block/drbd: align properly u64 in nl messages References: <20160503100644.GE16459@soda.linbit> <1462786820-15519-1-git-send-email-nicolas.dichtel@6wind.com> <20160509131547.GX16459@soda.linbit> To: davem@davemloft.net, netdev@vger.kernel.org, philipp.reisner@linbit.com, drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org From: Nicolas Dichtel Organization: 6WIND Message-ID: <5731A561.6090509@6wind.com> Date: Tue, 10 May 2016 11:09:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20160509131547.GX16459@soda.linbit> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 09/05/2016 15:15, Lars Ellenberg a écrit : > On Mon, May 09, 2016 at 11:40:20AM +0200, Nicolas Dichtel wrote: [snip] >> Maybe prefixing genl_magic_func.h and genl_magic_struct.h by 'drbd_' >> could be interesting so that new module won't use it. What is your >> opinion? > > This was supposed to not be DRBD specific. But it might even still > need some massaging before it was truly generic. And obviously, > it does not meet the taste of genetlink folks, to say the least :( Yes, this file is not generic and netlink APIs are never defined like this. These tons of macro complexifies the code too much. It's overengineering for what purpose? Small examples: - the drbd netlink API is not exported via uapi (I wonder how apps using this API get it) - v2 of the patch is nacked because adding a new attribute may break existing apps (in networking code, a lot of new attributes are added in each version) - it's not possible to grep to show the definition of an attribute ('git grep -w T_bits_total' returns only 1 line) Regards, Nicolas