From: Roger Quadros <rogerq@ti.com>
To: Felipe Balbi <balbi@kernel.org>
Cc: <tony@atomide.com>, <Joao.Pinto@synopsys.com>,
<sergei.shtylyov@cogentembedded.com>, <peter.chen@freescale.com>,
<jun.li@freescale.com>, <grygorii.strashko@ti.com>,
<yoshihiro.shimoda.uh@renesas.com>, <nsekhar@ti.com>,
<b-liu@ti.com>, <linux-usb@vger.kernel.org>,
<linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 4/5] usb: dwc3: omap: Pass VBUS and ID events transparently
Date: Tue, 10 May 2016 13:13:10 +0300 [thread overview]
Message-ID: <5731B436.6020801@ti.com> (raw)
In-Reply-To: <871t5ai5ye.fsf@linux.intel.com>
On 10/05/16 13:05, Felipe Balbi wrote:
>
> Hi,
>
> Roger Quadros <rogerq@ti.com> writes:
>> On 10/05/16 12:55, Felipe Balbi wrote:
>>>
>>> Hi,
>>>
>>> Roger Quadros <rogerq@ti.com> writes:
>>>> Don't make any decisions regarding VBUS session based on ID
>>>> status. That is best left to the OTG core.
>>>>
>>>> Pass ID and VBUS events independent of each other so that OTG
>>>> core knows exactly what to do.
>>>>
>>>> This makes dual-role with extcon work with OTG irq on OMAP platforms.
>>>>
>>>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>>>
>>> I have a feeling this will regress OMAP5432 uEVM. Did you test with that
>>> board ?
>>>
>>
>> Yes. Any specific test case you would like me to test?
>> For now I'm just doing enumeration with g_zero.
>
> IIRC OMAP5 uEVM didn't have separate VBUS and ID GPIOs. How are you
> handling that case ?
>
It comes from the PMIC, extcon-palmas.c.
cheers,
-roger
next prev parent reply other threads:[~2016-05-10 10:13 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 9:51 [PATCH v7 0/5] dwc3: omap: fixes and dual-role preparation Roger Quadros
2016-05-10 9:51 ` [PATCH v7 1/5] usb: dwc3: omap: use request_threaded_irq() Roger Quadros
2016-05-10 9:58 ` Felipe Balbi
2016-05-10 10:04 ` Roger Quadros
2016-05-10 10:12 ` Felipe Balbi
2016-05-10 10:21 ` Roger Quadros
2016-05-11 8:17 ` Roger Quadros
2016-05-11 9:47 ` Felipe Balbi
2016-05-11 11:46 ` Roger Quadros
2016-05-11 12:39 ` Felipe Balbi
2016-05-11 13:52 ` Roger Quadros
2016-05-10 9:51 ` [PATCH v7 2/5] usb: dwc3: omap: Mark the interrupt handler as shared Roger Quadros
2016-05-10 9:51 ` [PATCH v7 3/5] usb: dwc3: omap: Don't set POWERPRESENT Roger Quadros
2016-05-10 9:54 ` Felipe Balbi
2016-05-10 9:59 ` Roger Quadros
2016-05-10 10:04 ` Felipe Balbi
2016-05-10 10:23 ` Roger Quadros
2016-05-10 10:33 ` Felipe Balbi
2016-05-10 10:24 ` Roger Quadros
2016-05-10 9:51 ` [PATCH v7 4/5] usb: dwc3: omap: Pass VBUS and ID events transparently Roger Quadros
2016-05-10 9:55 ` Felipe Balbi
2016-05-10 10:00 ` Roger Quadros
2016-05-10 10:05 ` Felipe Balbi
2016-05-10 10:13 ` Roger Quadros [this message]
2016-05-10 10:13 ` Felipe Balbi
2016-05-10 9:51 ` [PATCH v7 5/5] usb: dwc3: core: cleanup IRQ resources Roger Quadros
2016-05-10 10:03 ` Felipe Balbi
2016-05-10 10:10 ` Roger Quadros
2016-05-10 10:14 ` Felipe Balbi
2016-05-10 11:45 ` Roger Quadros
2016-05-10 11:48 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5731B436.6020801@ti.com \
--to=rogerq@ti.com \
--cc=Joao.Pinto@synopsys.com \
--cc=b-liu@ti.com \
--cc=balbi@kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=jun.li@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=peter.chen@freescale.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tony@atomide.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).