From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751436AbcEJKxL (ORCPT ); Tue, 10 May 2016 06:53:11 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:47110 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751041AbcEJKxJ (ORCPT ); Tue, 10 May 2016 06:53:09 -0400 Subject: Re: [PATCH 1/2] drm/omapdrm: include pinctrl/consumer.h where needed To: Arnd Bergmann , David Airlie , Laurent Pinchart References: <1462830733-1710590-1-git-send-email-arnd@arndb.de> CC: Dave Gerlach , Rob Clark , Dave Airlie , , From: Tomi Valkeinen Message-ID: <5731BD88.1070401@ti.com> Date: Tue, 10 May 2016 13:52:56 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <1462830733-1710590-1-git-send-email-arnd@arndb.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JWmhGWFxfXw0Of0tqQsx1baWwEP85NJ4p" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --JWmhGWFxfXw0Of0tqQsx1baWwEP85NJ4p Content-Type: multipart/mixed; boundary="bq4ks67r9KX3mok1puLkU95jI1aU1RHRk" From: Tomi Valkeinen To: Arnd Bergmann , David Airlie , Laurent Pinchart Cc: Dave Gerlach , Rob Clark , Dave Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Message-ID: <5731BD88.1070401@ti.com> Subject: Re: [PATCH 1/2] drm/omapdrm: include pinctrl/consumer.h where needed References: <1462830733-1710590-1-git-send-email-arnd@arndb.de> In-Reply-To: <1462830733-1710590-1-git-send-email-arnd@arndb.de> --bq4ks67r9KX3mok1puLkU95jI1aU1RHRk Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/05/16 00:51, Arnd Bergmann wrote: > In some configurations, we can build the OMAP dss driver without > implictly including the pinctrl consumer definitions, causing > a build error: >=20 > gpu/drm/omapdrm/dss/dss.c: In function 'dss_runtime_suspend': > gpu/drm/omapdrm/dss/dss.c:1268:2: error: implicit declaration of functi= on 'pinctrl_pm_select_sleep_state' [-Werror=3Dimplicit-function-declarati= on] >=20 > This adds an explicit #include. >=20 > Signed-off-by: Arnd Bergmann > --- > drivers/gpu/drm/omapdrm/dss/dss.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/gpu/drm/omapdrm/dss/dss.c b/drivers/gpu/drm/omapdr= m/dss/dss.c > index f95ff319e68e..3303cfad4838 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dss.c > +++ b/drivers/gpu/drm/omapdrm/dss/dss.c > @@ -30,6 +30,7 @@ > #include > #include > #include > +#include > #include > #include > #include Thanks, queued for omapdrm fixes. Tomi --bq4ks67r9KX3mok1puLkU95jI1aU1RHRk-- --JWmhGWFxfXw0Of0tqQsx1baWwEP85NJ4p Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXMb2IAAoJEPo9qoy8lh71Hc8P/AzjQzmxvzZZY3CPAayWvndM go86mFtLBmeAQxJz8fgvWgNTksaiC2AdNufDhjPLYL/Av7/dJn56FnGYGEmk9StN iQBu8Pk5X1ekxJ+F1b+F/BfOUERMb7q39POAV72JIUOIdHumLK1ZcKT51tczj39h 1gr2QytlgNIzDYa14EK+/5iALwR+J3UvTSNNpBqRDcnspg/KpRpa1HdaZ8zcmia8 r0FVYGCnXOrjW/c27qNQX3MUwrUUIud2dFmgXNWA6yEwiBedp1mQtEd4LIgKnjlw l0CvntIPO2ia+BJO6bJjpSOg2CZcVC5dS2Ucsh1DPhXDt/5KvmVuHa+N4Grdk7Ho mocQm7D/0SgzYgEZ0a7GFtFM/WQ9C8lxe9+TaabTWC5C+/n+LXkQTS8QqOg+VN8U sqh5xH6o6n9iTgRkgat9ifVEVuUKi1LQ6oEB7RB6yXPNEM/zmUF59P7dv/Ymf3xP n+GYtkDZOQ3TqoFI8UsC9sgez+cgzobs/R6JKMrnGGnF9X3gBA90Cu+BBJ0TJp/K XkLmgurLSvw5cHtJbZHt239oQXcJ72oBuT6/ruYsKftbASXHqQR/vJTsH+Of9LcW n2zdEXDc9un6b+xCn49phm7QCTA2UhVr3VjMJGTdWNn3ttHEZ9HaYu0+ZWxTaE07 iO2AsZpFNcdEgfYOYoaq =ik3x -----END PGP SIGNATURE----- --JWmhGWFxfXw0Of0tqQsx1baWwEP85NJ4p--