Re: [PATCH 5/5] clk: hisilicon: hi3519: add driver remove path and fix some issues

Jiancheng Xue
2016-05-10T11:46:35Z

Hi Philipp,

On 2016/5/10 19:09, Philipp Zabel wrote:
> Am Dienstag, den 10.05.2016, 17:19 +0800 schrieb Jiancheng Xue:
>> 1. Add driver remove path.
>> 2. Fix some issues.
>> -Fix the ordering issue about clock provider being published.
>> -Add error checking upon registering clocks.
>>
>> Signed-off-by: Jiancheng Xue <xuejiancheng@hisilicon.com>
>> ---
>> drivers/clk/hisilicon/clk-hi3519.c | 116 ++++++++++++++++++++++++++++++++-----
>> 1 file changed, 100 insertions(+), 16 deletions(-)
>>
>> diff --git a/drivers/clk/hisilicon/clk-hi3519.c b/drivers/clk/hisilicon/clk-hi3519.c
>> index 715c730..51b173e 100644
>> --- a/drivers/clk/hisilicon/clk-hi3519.c
>> +++ b/drivers/clk/hisilicon/clk-hi3519.c
> [...]
>> - rstc = hisi_reset_init(np);
>> - if (!rstc)
> [...]
>> + crg->rstc = hisi_reset_init(pdev);
>> + if (!crg->rstc)
> [...]
>
> The hisi_reset_init(np) -> hisi_reset_init(pdev) change should be part
> of patch 1.
>
OK. I'll redivide this patch set and resend it. Thank you!

Regards,
Jiancheng