From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751910AbcEJMUH (ORCPT ); Tue, 10 May 2016 08:20:07 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:43894 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751347AbcEJMUF (ORCPT ); Tue, 10 May 2016 08:20:05 -0400 Subject: Re: [PATCH 18/23] drm: omapdrm: panel-dsi-cm: use threaded irq handler To: Sebastian Reichel , Tony Lindgren , Aaro Koskinen References: <1457455195-1938-1-git-send-email-sre@kernel.org> <1457455195-1938-19-git-send-email-sre@kernel.org> CC: Laurent Pinchart , David Airlie , , , From: Tomi Valkeinen Message-ID: <5731D1DF.5050304@ti.com> Date: Tue, 10 May 2016 15:19:43 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <1457455195-1938-19-git-send-email-sre@kernel.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mgai4hqmfwWVnXgveQbaohIMX6o8F9fnL" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --mgai4hqmfwWVnXgveQbaohIMX6o8F9fnL Content-Type: multipart/mixed; boundary="oS8JJt7XGolHAA3axq8W4GsWnADXwrDQd" From: Tomi Valkeinen To: Sebastian Reichel , Tony Lindgren , Aaro Koskinen Cc: Laurent Pinchart , David Airlie , linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Message-ID: <5731D1DF.5050304@ti.com> Subject: Re: [PATCH 18/23] drm: omapdrm: panel-dsi-cm: use threaded irq handler References: <1457455195-1938-1-git-send-email-sre@kernel.org> <1457455195-1938-19-git-send-email-sre@kernel.org> In-Reply-To: <1457455195-1938-19-git-send-email-sre@kernel.org> --oS8JJt7XGolHAA3axq8W4GsWnADXwrDQd Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/03/16 18:39, Sebastian Reichel wrote: > Use threaded irq handler for the tearing effect gpio, > since it updates the display content, which requires > too much time for a fastpath irq. >=20 > Signed-off-by: Sebastian Reichel > --- > drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c b/drivers/= gpu/drm/omapdrm/displays/panel-dsi-cm.c > index 768e92d1ec8b..8316b6c2d8aa 100644 > --- a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c > +++ b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c > @@ -1317,9 +1317,9 @@ static int dsicm_probe(struct platform_device *pd= ev) > return r; > } > =20 > - r =3D devm_request_irq(dev, gpio_to_irq(ddata->ext_te_gpio), > - dsicm_te_isr, > - IRQF_TRIGGER_RISING, > + r =3D devm_request_threaded_irq(dev, gpio_to_irq(ddata->ext_te_gpio)= , > + NULL, dsicm_te_isr, > + IRQF_TRIGGER_RISING | IRQF_ONESHOT, > "taal vsync", ddata); > =20 > if (r) { >=20 I don't have a problem with moving to threaded irq, but it does make me wonder, what's happening there that's taking so much time? I think it should be just writing the configs to the registers and starting the transfer. Tomi --oS8JJt7XGolHAA3axq8W4GsWnADXwrDQd-- --mgai4hqmfwWVnXgveQbaohIMX6o8F9fnL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXMdHfAAoJEPo9qoy8lh71B0MP/1t0lya9iY/+RchJYF5YbAds Xp9Iqnp+9xTMoFXZ2F7bhHph5qFo7nJPk7mnxqB3i5Gv0kb+boWg3Ie+mJzySY7U XL0YKUr5l+FMky851ZaCpgVU8/yBD2TE0YwG0m+5wfMTPYvP3ZTtiZGrlmWnMChO tHTRU0NljW3imOvIT60iR4rezAmGmzzMopsZIeqtiWh9uBukbGAvIEHidZQBmmoR zPNivakq4WDK2fQ1ygkOEImoSIP6mtXRedU0A/hfsDRRNEhSebJ2hzd3zODlwPZV A2GnOrInVrbfi3VYiHAGf+L2+qMEBjAez63G5S7Egc4427iTITxomLXEsK1MU2iT 5kQgXYfPZxpTuyFonVDjfurU7pEuKVB5Q2NWHzx7fFilMXDZWSOJNj593ywq6MQW 1C8qN+zj/E3D0g90bqHRvEEW5Y6cmbscoedPYe/PzuLb42huvkzEG0HZYA6qJW15 kuRVolnUBkNIb6jkTThzgUBYg2STYfbhUb96VtYOv33pPefJWishsbU8os5CQnjr vyMOwa93JI2sFTT5BaRYir8CGfErOr9RCfknkD89Wv+2PopVivkBBL1ROT/leot4 NuaoHYd6rua62Q+xpbsgS4REJS3p3ritzQMvMJedpKw7t9M9VwWyR7A5qlpX55QE 40fvqk1u0siV3EbYffbL =oiep -----END PGP SIGNATURE----- --mgai4hqmfwWVnXgveQbaohIMX6o8F9fnL--