From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752148AbcEJMlq (ORCPT <rfc822;w@1wt.eu>);
	Tue, 10 May 2016 08:41:46 -0400
Received: from eusmtp01.atmel.com ([212.144.249.242]:57171 "EHLO
	eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750974AbcEJMlo (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 10 May 2016 08:41:44 -0400
Subject: Re: [PATCH] ARM: at91/defconfig: sama5: add CONFIG_FHANDLE
To: Marek Vasut <marex@denx.de>
References: <572CC603.4000102@denx.de>
 <1462867383-31961-1-git-send-email-nicolas.ferre@atmel.com>
 <5731D49E.3080307@denx.de>
CC: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
        <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        "Boris BREZILLON" <boris.brezillon@free-electrons.com>,
        <Venkateshprabhu.Subramanian@atmel.com>, <m.olbrich@pengutronix.de>,
        "Ludovic Desroches" <ludovic.desroches@atmel.com>
From: Nicolas Ferre <nicolas.ferre@atmel.com>
Organization: atmel
Message-ID: <5731D71A.5080500@atmel.com>
Date: Tue, 10 May 2016 14:42:02 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <5731D49E.3080307@denx.de>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.161.30.18]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Le 10/05/2016 14:31, Marek Vasut a écrit :
> On 05/10/2016 10:03 AM, Nicolas Ferre wrote:
>> CONFIG_FHANDLE is listed as a mandatory kernel option for systemd. So
>> explicitly enable it to allow easy use of systemd userspace.
>>
>> Reported-by: Marek Vasut <marex@denx.de>
>> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>> ---
>> Hi Marek,
> 
> Hi!
> 
>> It seems that on my side, CONFIG_FHANDLE is not selected automatically...
>> So I add this patch: can you tell me your thoughts?
> 
> Uh, weird, I tried this on next just now:
> 
> linux-2.6$ git describe HEAD
> next-20160510
> 
> linux-2.6$ export ARCH=arm ; export CROSS_COMPILE=arm-linux-gnueabi-
> 
> linux-2.6$ make sama5_defconfig ; grep FHANDLE .config
>   HOSTCC  scripts/basic/fixdep
>   HOSTCC  scripts/kconfig/conf.o
>   SHIPPED scripts/kconfig/zconf.tab.c
>   SHIPPED scripts/kconfig/zconf.lex.c
>   SHIPPED scripts/kconfig/zconf.hash.c
>   HOSTCC  scripts/kconfig/zconf.tab.o
>   HOSTLD  scripts/kconfig/conf
> #
> # configuration written to .config
> #
> CONFIG_FHANDLE=y

Absolutely. The patch f76be61755c5 ("Make CONFIG_FHANDLE default y") has
been added in v4.6-rc2... while I was doing my tests on at91-next that
is based on v4.6-rc1 :-\

Anyway. It's in now. Thanks,

Bye,
   Nicolas

>>  arch/arm/configs/sama5_defconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/configs/sama5_defconfig
>> index 307f92b31e57..9cb1a85bb166 100644
>> --- a/arch/arm/configs/sama5_defconfig
>> +++ b/arch/arm/configs/sama5_defconfig
>> @@ -1,6 +1,7 @@
>>  # CONFIG_LOCALVERSION_AUTO is not set
>>  # CONFIG_SWAP is not set
>>  CONFIG_SYSVIPC=y
>> +CONFIG_FHANDLE=y
>>  CONFIG_IRQ_DOMAIN_DEBUG=y
>>  CONFIG_LOG_BUF_SHIFT=14
>>  CONFIG_CGROUPS=y
>>
> 
> 


-- 
Nicolas Ferre