From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752674AbcEJOuI (ORCPT ); Tue, 10 May 2016 10:50:08 -0400 Received: from mail-wm0-f47.google.com ([74.125.82.47]:35701 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751262AbcEJOuF (ORCPT ); Tue, 10 May 2016 10:50:05 -0400 Subject: Re: [PART1 V5 08/13] svm: Add interrupt injection via AVIC To: Borislav Petkov , Suravee Suthikulpanit References: <1462388992-25242-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1462388992-25242-9-git-send-email-Suravee.Suthikulpanit@amd.com> <20160510091956.GB16752@pd.tnic> Cc: rkrcmar@redhat.com, joro@8bytes.org, gleb@kernel.org, alex.williamson@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, wei@redhat.com, sherry.hurwitz@amd.com From: Paolo Bonzini Message-ID: <5731F518.9000205@redhat.com> Date: Tue, 10 May 2016 16:50:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <20160510091956.GB16752@pd.tnic> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/05/2016 11:19, Borislav Petkov wrote: >> > This patch introduces a new mechanism to inject interrupt using AVIC. >> > Since VINTR is not supported when enable AVIC, we need to inject > "... is not supported when AVIC is enabled ..." > > VINTR? The ability to request a vmexit as soon as an interrupt can be injected (IF=GIF=1, no interrupt window, etc.). It's called the "VINTR intercept". > Please write those things out in the commit message for maximum > information transfer to the reader. :) More important, where does the APM document that VINTR is not supported when AVIC is enabled? It is certainly pointless and inefficient, but I'm not sure where it says that it doesn't work. Paolo