From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753247AbcEJPY4 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 10 May 2016 11:24:56 -0400
Received: from lists.s-osg.org ([54.187.51.154]:40883 "EHLO lists.s-osg.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752560AbcEJPYy (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 10 May 2016 11:24:54 -0400
Subject: Re: [PATCH 1/2] kselftests/ftrace: Detect tracefs mount point
To: Namhyung Kim <namhyung@kernel.org>, Steven Rostedt <rostedt@goodmis.org>
References: <1462891986-3608-1-git-send-email-namhyung@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        linux-kselftest@vger.kernel.org
From: Shuah Khan <shuahkh@osg.samsung.com>
Message-ID: <5731FD43.7090109@osg.samsung.com>
Date: Tue, 10 May 2016 09:24:51 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <1462891986-3608-1-git-send-email-namhyung@kernel.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/10/2016 08:53 AM, Namhyung Kim wrote:
> Currently ftracetest assumes tracing directory is located under
> $DEBUGFS/tracing.  But it's possible to mount tracefs directly without
> debugfs.
> 
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>

Looks good to me. Steve! Ack if you are good with this patch.
I can get this into 4.8-rc1

thanks,
-- Shuah

> ---
>  tools/testing/selftests/ftrace/ftracetest | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest
> index da48812ab95e..4c6a0bf8ba79 100755
> --- a/tools/testing/selftests/ftrace/ftracetest
> +++ b/tools/testing/selftests/ftrace/ftracetest
> @@ -88,7 +88,12 @@ parse_opts() { # opts
>  
>  # Parameters
>  DEBUGFS_DIR=`grep debugfs /proc/mounts | cut -f2 -d' ' | head -1`
> -TRACING_DIR=$DEBUGFS_DIR/tracing
> +if [ -z "$DEBUGFS_DIR" ]; then
> +    TRACING_DIR=`grep tracefs /proc/mounts | cut -f2 -d' ' | head -1`
> +else
> +    TRACING_DIR=$DEBUGFS_DIR/tracing
> +fi
> +
>  TOP_DIR=`absdir $0`
>  TEST_DIR=$TOP_DIR/test.d
>  TEST_CASES=`find_testcases $TEST_DIR`
> @@ -102,7 +107,7 @@ parse_opts $*
>  [ $DEBUG -ne 0 ] && set -x
>  
>  # Verify parameters
> -if [ -z "$DEBUGFS_DIR" -o ! -d "$TRACING_DIR" ]; then
> +if [ -z "$TRACING_DIR" -o ! -d "$TRACING_DIR" ]; then
>    errexit "No ftrace directory found"
>  fi
>  
>