From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753120AbcEJQNm (ORCPT ); Tue, 10 May 2016 12:13:42 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:13415 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752428AbcEJQNk (ORCPT ); Tue, 10 May 2016 12:13:40 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Tue, 10 May 2016 09:12:05 -0700 Subject: Re: [PATCH] mmc: tegra: Disable UHS-I modes for tegra30 To: Adrian Hunter , Ulf Hansson , Stephen Warren , "Thierry Reding" , Alexandre Courbot References: <1462806903-13860-1-git-send-email-jonathanh@nvidia.com> CC: , , , Lucas Stach From: Jon Hunter X-Nvconfidentiality: public Message-ID: <573208AD.4090506@nvidia.com> Date: Tue, 10 May 2016 17:13:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <1462806903-13860-1-git-send-email-jonathanh@nvidia.com> X-Originating-IP: [10.21.132.102] X-ClientProxiedBy: UKMAIL102.nvidia.com (10.26.138.15) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/05/16 16:15, Jon Hunter wrote: > Support for SD cards is not working on the Tegra30 Beaver board and on > boot the following error message is seen if an SD card is present: > > mmc0: error -110 whilst initialising SD card > > In addition to this, Tegra30 is also randomly hanging during system > suspend when entering and is caused by the Tegra SDHCI driver. Similar > issues have been seen on the Tegra124 Jetson TK1 and are linked to the > UHS-I tuning sequence. Disabling the UHS-I modes for Tegra30 fixes SD > card support and prevents any hangs from occurring when entering system > suspend. Therefore, disable the UHS-I modes for Tegra30 for now until > we can correct the tuning sequence for Tegra. > > Signed-off-by: Jon Hunter > --- > drivers/mmc/host/sdhci-tegra.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c > index bcc0de47fe7e..24c33aee8e7c 100644 > --- a/drivers/mmc/host/sdhci-tegra.c > +++ b/drivers/mmc/host/sdhci-tegra.c > @@ -347,10 +347,6 @@ static const struct sdhci_pltfm_data sdhci_tegra30_pdata = { > > static const struct sdhci_tegra_soc_data soc_data_tegra30 = { > .pdata = &sdhci_tegra30_pdata, > - .nvquirks = NVQUIRK_ENABLE_SDHCI_SPEC_300 | Ugh ... looks like I may have been a bit trigger happy with sending this patch. I should not have removed the above line. However, it seems that if I don't then the problem with the SD not initialising persists. So this implies that something else is going on here with this particular SD card. Furthermore, I have seen that another tegra30-beaver is initialising the SD card fine on kernelci.org and it seems this is working for Lucas too. Plus in suspend I have not seen the mmc timeout warning that I was seeing on tegra114/124 when they were failing. That also implies a different problem. Stephen, for your u-boot testing, do you are set the bit in the vendor misc register to enable version 3.0 support for sdhci on tegra30? This is what the above quirk is doing (and has done so for a very long time). Sorry I am usually more thorough ... Jon