From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751795AbcEJRTu (ORCPT ); Tue, 10 May 2016 13:19:50 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:53941 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751739AbcEJRTs (ORCPT ); Tue, 10 May 2016 13:19:48 -0400 Subject: Re: [PATCH v2] drm/vc4: Return -EBUSY if there's already a pending flip event. To: Eric Anholt , daniel.vetter@ffwll.ch, airlied@linux.ie, aniel.vetter@ffwll.ch, fengguang.wu@intel.com, maarten.lankhorst@linux.intel.com, julia.lawall@lip6.fr, alexander.deucher@amd.com, daniels@collabora.com, derekf@osg.samsung.com, varadgautam@gmail.com References: <1462297700-17491-1-git-send-email-robert.foss@collabora.com> <8737pzlzfr.fsf@eliezer.anholt.net> <5731FFA8.8040304@collabora.com> <87eg99yha2.fsf@eliezer.anholt.net> Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org From: Robert Foss Message-ID: <5732182E.6090100@collabora.com> Date: Tue, 10 May 2016 13:19:42 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <87eg99yha2.fsf@eliezer.anholt.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks Eric! On 2016-05-10 01:06 PM, Eric Anholt wrote: > Robert Foss writes: > >> On 2016-05-03 03:22 PM, Eric Anholt wrote: >>> robert.foss@collabora.com writes: >>> >>>> From: Robert Foss >>>> >>>> As per the documentation in drm_crtc.h, atomic_commit should return >>>> -EBUSY if an asycnhronous update is requested and there is an earlier >>>> update pending. >>>> >>>> Note: docs cited here are drm_crtc.h, and the whole quote is: >>>> >>>> * - -EBUSY, if an asynchronous updated is requested and there is >>>> * an earlier updated pending. Drivers are allowed to support a queue >>>> * of outstanding updates, but currently no driver supports that. >>>> * Note that drivers must wait for preceding updates to complete if a >>>> * synchronous update is requested, they are not allowed to fail the >>>> * commit in that case. >>>> >>>> Signed-off-by: Robert Foss >>> >>> This looks good to me. Let's give it a few days on the list for any >>> other KMS folks to catch anything. >>> >> >> I haven't seen any further feedback regarding this patch. >> Does anyone have objections to it being merged? > > I merged it to drm-vc4-next last night, actually :) >