From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751462AbcEKFt1 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 11 May 2016 01:49:27 -0400
Received: from mailout2.w1.samsung.com ([210.118.77.12]:38033 "EHLO
	mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751152AbcEKFtZ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 11 May 2016 01:49:25 -0400
X-AuditID: cbfec7f5-f792a6d000001302-a4-5732c7e142c6
Subject: Re: [PATCH] ARM: dts: exynos: Only Odroid XU3-family boards use DTSI
 with CPU thermal nodes
To: Anand Moon <linux.amoon@gmail.com>
References: <1462774789-15360-1-git-send-email-k.kozlowski@samsung.com>
 <CANAwSgT9SY3kj8+beMpc1xGoC=rMBSya+2v2dyZQp6ykH+V0=g@mail.gmail.com>
 <573198BE.6020900@samsung.com>
 <CANAwSgTy6p9AVmmOWATpSO1JqVbwE0v+y_y-RLd+32RnNJTA+Q@mail.gmail.com>
 <5731D764.8070007@samsung.com>
 <CANAwSgRsjdQh6ygT__5XcH8-cF9Ch+zbk8oupebwYzY1kCZu6g@mail.gmail.com>
 <5731EA1B.4070201@samsung.com>
 <CANAwSgQGhrBca7=Ow8+Hh9t0W9HWp=F43KR0Frfpx9fGngPSaw@mail.gmail.com>
Cc: Kukjin Kim <kgene@kernel.org>, Lukasz Majewski <l.majewski@samsung.com>,
        Javier Martinez Canillas <javier@osg.samsung.com>,
        devicetree <devicetree@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        "linux-samsung-soc@vger.kernel.org" 
	<linux-samsung-soc@vger.kernel.org>,
        Linux Kernel <linux-kernel@vger.kernel.org>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Message-id: <5732C7DF.2080800@samsung.com>
Date: Wed, 11 May 2016 07:49:19 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-version: 1.0
In-reply-to: <CANAwSgQGhrBca7=Ow8+Hh9t0W9HWp=F43KR0Frfpx9fGngPSaw@mail.gmail.com>
Content-type: text/plain; charset=utf-8
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrDLMWRmVeSWpSXmKPExsVy+t/xa7oPjxuFG/TcELLYOGM9q8X8I+dY
	Ld68XcNk8fqFoUX/49fMFm8ebma02PT4GqvF5V1z2CxmnN/HZLFu4y12By6PnbPusntsWtXJ
	5rF5Sb3Hln4gr2/LKkaPz5vkAtiiuGxSUnMyy1KL9O0SuDL+TN7NWvCEvWLWn41sDYwzWLsY
	OTgkBEwkzmyT72LkBDLFJC7cW8/WxcjFISSwlFHi5N23jCAJIYFnQM75cBBbWCBNYuuuxcwg
	toiAmsSVpytYIRqOMUvMb9/ADOIwC8xglrj+8iUTSBWbgLHE5uVL2EBsXgEtifU/P4HZLAKq
	Es2tfawgtqhAhMTqddeYIWoEJX5MvscCYnMKBEv8vvecEeRSZgF1iSlTckHCzALyEpvXvGWe
	wCgwC0nHLISqWUiqFjAyr2IUTS1NLihOSs810itOzC0uzUvXS87P3cQIiYOvOxiXHrM6xCjA
	wajEw7uhyihciDWxrLgy9xCjBAezkgjv36NAId6UxMqq1KL8+KLSnNTiQ4zSHCxK4rwzd70P
	ERJITyxJzU5NLUgtgskycXBKNTBmbBBpCDWZINI/Z+La1vMXW6IrmR/zJG2ZsYrpPd8ZXYsX
	ExLnz2XIX7Tl19z7dvribNIz/8xOknxpIzGZqUtsez2zw+TXC8vdjhk63xVK+1ls+Nj40rYj
	j5IUj337tI5Z7Wnzn0DPHB3+119aBU36/3VP23395/nkZQ17501au+GT6wuf1kx7JZbijERD
	Leai4kQA0kHN3H8CAAA=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/10/2016 09:45 PM, Anand Moon wrote:
> Hi Krzysztof,
> 
> Sorry I am not able to explain my self clearly.
> But I have once gain tested these changes.
> 
> Only could you append with following changes.
> --------------------------------------------------------
> +                               cpu_crit0: cpu-crit-0 {
> +                                       temperature = <120000>; /*
> millicelsius */
> +                                       hysteresis = <5000>; /* millicelsius */
> +                                       type = "critical";
> +                               };
> --------------------------------------------------------
> hysteresis time help to adjust the present and past temperature inputs
> before critical shutdown.

I need more details why you want this patch. What is the point of
hysteresis on critical trip point? When reaching this trip point the
system shutdowns... there is nothing more to do, I think.

Best regards,
Krzysztof