From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751916AbcEKJil (ORCPT <rfc822;w@1wt.eu>);
	Wed, 11 May 2016 05:38:41 -0400
Received: from foss.arm.com ([217.140.101.70]:50323 "EHLO foss.arm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751129AbcEKJij (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 11 May 2016 05:38:39 -0400
Subject: Re: [PATCH] arm64: cpuinfo: Missing NULL terminator in
 compat_hwcap_str
To: Mark Rutland <mark.rutland@arm.com>
References: <1462891231-17605-1-git-send-email-julien.grall@arm.com>
 <20160510145441.GC10785@leverpostej>
Cc: linux-arm-kernel@lists.infradead.org, will.deacon@arm.com,
        linux-kernel@vger.kernel.org, catalin.marinas@arm.com,
        stable@vger.kernel.org, "Suzuki K. Poulose" <suzuki.poulose@arm.com>
From: Julien Grall <julien.grall@arm.com>
Message-ID: <5732FD9C.8000503@arm.com>
Date: Wed, 11 May 2016 10:38:36 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0)
 Gecko/20100101 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <20160510145441.GC10785@leverpostej>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Mark,

On 10/05/2016 15:54, Mark Rutland wrote:
> On Tue, May 10, 2016 at 03:40:31PM +0100, Julien Grall wrote:
>> The loop that browses the array compat_hwcap_str will stop when a NULL
>> is encountered, however NULL is missing at the end of array. This will
>> result to overrun until one NULL is found somewhere in the memory.
>
> Probably worth adding something like:
>
> Note for backporting: commit 12d11817eaafa414 ("arm64: Move
> /proc/cpuinfo handling code") moved this code. Prior to that commit, the
> same change should be made in arch/arm64/kernel/setup.c.

I can resend the patch with this changes.

>
>> Fixes: 44b82b7700d0 "arm64: Fix up /proc/cpuinfo"
>> Signed-off-by: Julien Grall <julien.grall@arm.com>
>> Cc: stable@vger.kernel.org
>>
>> ---
>>
>> Cc: Mark Rutland <mark.rutland@arm.com>
>> Cc: Suzuki K. Poulose <suzuki.poulose@arm.com>
>> ---
>
> Wierd middle '---' between the Cc lines above.

It is an habit I have with Xen-devel as the Cc are not necessary after 
it has been committed.

>
> Otherwise:
>
> Reviewed-by: Mark Rutland <mark.rutland@arm.com>

Thank you!

Regards,

-- 
Julien Grall