From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751816AbcEKLob (ORCPT ); Wed, 11 May 2016 07:44:31 -0400 Received: from mail-db3on0127.outbound.protection.outlook.com ([157.55.234.127]:35275 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750979AbcEKLo3 (ORCPT ); Wed, 11 May 2016 07:44:29 -0400 Authentication-Results: google.com; dkim=none (message not signed) header.d=none;google.com; dmarc=none action=none header.from=virtuozzo.com; Subject: Re: [PATCH] mm-kasan-initial-memory-quarantine-implementation-v8-fix To: Alexander Potapenko References: <1462887534-30428-1-git-send-email-aryabinin@virtuozzo.com> CC: Andrew Morton , kasan-dev , Linux Memory Management List , LKML , Dmitry Vyukov From: Andrey Ryabinin Message-ID: <57331368.9070101@virtuozzo.com> Date: Wed, 11 May 2016 14:11:36 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: VI1PR07CA0108.eurprd07.prod.outlook.com (10.165.229.162) To DB6PR0801MB1304.eurprd08.prod.outlook.com (10.168.11.22) X-MS-Office365-Filtering-Correlation-Id: 71c23d82-17d7-4ea2-faf4-08d3798cf0ac X-Microsoft-Exchange-Diagnostics: 1;DB6PR0801MB1304;2:788w+lRoERxQf/HoJcux1B+PaSqxzEdnA02i8Bzice/KI9S4ehCg3+JMi/p47bZ37yj/z/upBkJz2+n1meF36g+whBQicZfhKZ7h6jCH1YKa2Md7mT5EIjSZQsW2kQpV1rGvBBvkFEmCYiSn8ERpGOxBXMDn/yuzgbHZWqlNv6w6hkMYwExNvMvRiiajY8Eq;3:d0wLi5b7gY48cUpLpekBo+7xw0c2vXW4McCWrlqphRkVvjToqe/B0RZp6UQW8w64W596UVC3nF5GELUdwLmctb477MR+dbwJMFABQIpF2qD7hGu1hzkf2/zFMKY1F3xM;25:ro4HW5weMSyIg3CJYslY3/UZVJu1mQZQFrRK9T+QDRv/C3n1j+DPJ4fq+dzYthxzOJWHY4wTNHy2YebX7VE38Vt0lbvrVSrz6eHEkJy5+ZFLQZJ+e8BhScsNd0yaKHtx/NR0GFXzl6pXTvcNZryAo7JseLIOeFs2TdbNAXgV1LRMLdckK5l9cUKKLob5djQqbjYle4m9V3Mym7QXCrFn6RphK4wEfBkpQVjm36RCpL5vavguoD2xR2+XSTKX3qBaZu/3JOC/loMx1L3S9siQ2K95y0cD8KgTyX/9/MF2PDVa4M9MZipjtJlAEM2R5+Ho7+cH4mXADVnBT7dD6QmYu+SHRD5rfgBBtnxUWFcYAMF7Pq1oveIV7wQ2wtH2Y66q0KeqJ0ZOzog9ZL9UNuA8sEdIddYNiuxsT9+2kB5gp3hiEFBcUYx0oXjMpnwHpJ/V X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0801MB1304; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040130)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041072)(6043046);SRVR:DB6PR0801MB1304;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0801MB1304; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0801MB1304;4:7YzTjRgcvL/poiaaxz/9z05DpSXPDFRAG/oyDoNUGzHakYqNnJA+N9TbU28+rriNrMTv7WybmCVoOjyzGqtWRBnaodMp/tWIHSAhUs//HIDswZGULXnVa8Vy3qsUAOc8eK9NO/OX63jP9CjCpVm9i45BEMPfL9F/JUVD54NVq2ubE+IRQtiKbHocy6eP0fnGgnbeFDODpygrBvlTdpy8BBwdJqKUy+V8nLCDGJsL4zbCJDxqdZgW/zd+pAB9BLb1BlDSyf2PCUzizRR9mZdCIYFvT6V2N9HOXyNzH2mpVG8SLW01NgvkO1bazTJDcc6UnYmD/+M3DxgxNe2WXpbQVfz21KBx9mKXbvTjDfwqwYnD4N58OmsPpoV7lftyLo21a4Iq2rO5E4ewHUoaZI1IEAuFpEteQ6fZVcJtgasmqo0= X-Forefront-PRVS: 0939529DE2 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(6049001)(24454002)(377454003)(5004730100002)(47776003)(99136001)(66066001)(50986999)(36756003)(65806001)(23676002)(54356999)(5008740100001)(189998001)(2950100001)(76176999)(87266999)(117636001)(92566002)(230700001)(230783001)(122286003)(59896002)(65956001)(77096005)(65816999)(110136002)(19580405001)(83506001)(42186005)(3846002)(4001350100001)(6116002)(19580395003)(81166006)(2906002)(86362001)(586003)(50466002)(4326007)(62816006);DIR:OUT;SFP:1102;SCL:1;SRVR:DB6PR0801MB1304;H:[10.30.25.228];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjZQUjA4MDFNQjEzMDQ7MjM6bXM0bWMySFVKeVJidjFvUXRIdUx3a25L?= =?utf-8?B?RmgyVDhZdzJyZXYvSURsbjA5bzIxRUlMekt5SVBsM0g2ZXAwSmVIME9USjJ4?= =?utf-8?B?SWFrWENoUSsvamRGTnBHbkZtQ1JkZVV4dTZ3N2lGcDRmQ0FEcFcyLzZIdXEz?= =?utf-8?B?amNYbkpRV2hRcEhVRk91OUJ4ODFzUm9iY2oyZ3F2OUhxQW5XWmxvR1Y1TnJs?= =?utf-8?B?NG9pa1NwQldtRTJxWE9xL29aYVlkM1Izd3hrekZ1eENUSmZxZTJjVTZKN3BR?= =?utf-8?B?aEdJQUt0M1gvbzBMMzJjZUp6RFFFQlZvRTR3U2xrZHNSVW5XYjlEa0NSMHA4?= =?utf-8?B?N1U2UmZPRWlPbWtRVmNrSnlZM3hkOENFTjYzYTZlSXk2N2V4SERMcElhMWZS?= =?utf-8?B?OXB4SCtmM3Y5Y0ZtTXlEbHNCQ2xNREZOTzEzWWpkNHg1UmNzaGUwazlUemJh?= =?utf-8?B?R05WdjZiRmFFdlExNXlUVkQ3cVFRMmdtNmdQYnQ0UHgxRzM3c2NkZkl3MTJB?= =?utf-8?B?eTVjN2daM3ZwVW5EaWVSbTdFQ1JHWTNpRGxJMTdldXB3M2F3WnZsL3ZodkJH?= =?utf-8?B?UlpLanMweVlvZ3FUVmhmTFMySWMvTEVwN01jVkx5amVlWFNvZ3NPUDl4cW1Z?= =?utf-8?B?WTNHUDhOUm5JUCt6empZYXdCa0dRN3VLMFN5WVRjSFZyenpaWGVIemJPY0pa?= =?utf-8?B?c3FTZnJUYmhmb2NVdEdYL2R0VkRpcmJaOHZQb2RzT1RxTlJYUGhwSjc0UDkw?= =?utf-8?B?dERxbTFFbmtZMTNjb3JVczExZUswNk1DVzAxNk1adFRENmFSZDRvanJmWnVo?= =?utf-8?B?OS96emRNQmZ2ZGg5NGVnaEd4b1kyc1c1UExNaUFQYk03WTN3UHlOaFAvUS8w?= =?utf-8?B?MzYzOXJmV1ZIenhKeTUyeE1oSnd0MnQvWG9CU2t6dURLeU9uc2pibTJ6akNS?= =?utf-8?B?NEUyREtYQi9FS0RvSUNSdHExMEllcUxwbE4raHE5VmE3RWhxcFRFcXl6WUJG?= =?utf-8?B?aVB1N0RSakVNdGZBa0JKUTFPMUlsV0pNTy81MTVQYUZySHVMRHF2SnJIK3h2?= =?utf-8?B?dzgxRERiODRXUml4UjlCNWVFQ0xkVC9RcStUZ3p2dTAxSFZWNjNramw3RnVH?= =?utf-8?B?RFo5SzlOVWlic3U1T1JFcnYzTDJDZ2ROYVI1cDdLa0ZJa1EvbVhLQkhkZnYv?= =?utf-8?B?dlBJM29IUG82bFlHTUE3VVR1eGk5dWRJcWVkTlAvZERsT2Zuc0FsL1BTMWRG?= =?utf-8?B?NGdwbFMzcXArbEo0SlY4SFlocmkwUGdBQk81bHROdGhPMG5pTFBwdGI5SXA0?= =?utf-8?B?KzYvN3hxQlJhSHFmZUxhY2xweW9IWC9mNm93NER4eTRJeDZyc1BDQllmZVRU?= =?utf-8?B?UFcyTjF0aXB2a0R2M0FmYVFZWXNUcnpQQ29CQzFwYjB0cWVIQVJuU2hDNzNI?= =?utf-8?B?RklQdDBPWXl1VUhmMCttVG16OXJBdUV5eExXWDZZQ2NETkRRTlNKQU1CYko2?= =?utf-8?B?MjZxRHFRPT0=?= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0801MB1304;5:RoX3dg9SzalLSnoFXupZEMlswnca07BMBtfYZxFxLUYGzc8NdF+7ABsgw2Sd8YXOG3RRfnpD0tBdZZjStJg2GMa5oofS158Ngxg2z75VGwsphAhByuI20Qac4DfuBTy0LHswRuaCtHabH/hCUNvFdA==;24:ROPJL6CVlNWyFSF2Jpj1+cg5gqYc+E+JzhkfjeYcmjvmmkNF2OLqdJeRnLhHlgY2UGIiyejhnSuPe6WYen0hUsMgEZ+3yNSbj754SgCv/8E=;7:QDutjc9jWdRScb0xICs+9MyuNgqWN747H5pWVS02crocStp3acIzh0oGquhwWSIZyL/LofWakkK0prqwQjqLS2jO+6Br1F7+u4N6l2PN2iaQxP1GFnS13gPrMZJGk0TxoWSASBs+2qHnby3GDg9+G3iPkJMVgWbGnsSIke7qPvzWAbBmvwuB2fUtdiyZQiJU;20:JjImPT7BnQEUO3dRW9oMNaM/KL1VOHVf1UVbFEka1/lOeKXzsOxd5FHpREDEllsP6RZvLWHOBuZyYiuP4rfnlqoGIkBOaO1kPQPoFZbUfciFGW17AcQT6TomHXPb4nXeUle7O0xCT8i7Mr6WVPQGhHZ6tXKLMm9uYiGzfIWqmQo= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2016 11:11:02.1184 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1304 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/11/2016 01:18 PM, Alexander Potapenko wrote: > On Tue, May 10, 2016 at 3:38 PM, Andrey Ryabinin > wrote: >> * Fix comment styles, > yDid you remove the comments from include/linux/kasan.h because they > were put inconsistently, or was there any other reason? We usually comment functions near definition, not declarations. If you like, put comment back. Just place it near definition. >> * Get rid of some ifdefs > Thanks! >> * Revert needless functions renames in quarantine patch > I believe right now the names are somewhat obscure. I agree however > the change should be done in a separate patch. Besides that, I didn't like the fact that you made names longer and exceeded 80-char limit in some places. >> * Remove needless local_irq_save()/restore() in per_cpu_remove_cache() > Ack >> * Add new 'struct qlist_node' instead of 'void **' types. This makes >> code a bit more redable. > Nice, thank you! > > How do I incorporate your changes? Is it ok if I merge it with the > next version of my patch and add a "Signed-off-by: Andrey Ryabinin > " line to the description? > Ok, but I don't think that this is matters. Andrew will just craft a diff patch on top of the current code anyways. Or you can make such diff by yourself and send it, it's easier to review, after all.