From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932704AbcEKNq2 (ORCPT ); Wed, 11 May 2016 09:46:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58283 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932667AbcEKNq0 (ORCPT ); Wed, 11 May 2016 09:46:26 -0400 Subject: Re: [Nbd] Fwd: [PATCH v4 02/18] nbd: fix checkpatch trailing space warning. To: Pranay Srivastava , Greg KH References: <1462954726-11825-1-git-send-email-pranjas@gmail.com> <1462954726-11825-3-git-send-email-pranjas@gmail.com> <20160511083331.GA29268@kroah.com> Cc: nbd-general@lists.sourceforge.net, linux-kernel@vger.kernel.org From: Eric Blake Openpgp: url=http://people.redhat.com/eblake/eblake.gpg Organization: Red Hat, Inc. Message-ID: <573337B1.6030900@redhat.com> Date: Wed, 11 May 2016 07:46:25 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Lus2fEp02vhKeNfI6F62ROvKGNBUX7uP0" X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 11 May 2016 13:46:26 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Lus2fEp02vhKeNfI6F62ROvKGNBUX7uP0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/11/2016 03:38 AM, Pranay Srivastava wrote: >=20 > The series contained some checkpatch changes so I had included you as w= ell. >=20 >> know why you are sending them to me), but I know I do not accept patch= es >> without any changelog text at all in them, as that's just lazy. >=20 > That should be per patch or can appear in a cover letter for the patche= s? Per patch. However, if it were me, I would not have split into quite so many patches. The mantra is one patch per one fix, but I think it is reasonable to state that "silence all checkpatch warnings" counts as one fix, rather than 16 separate fixes. If you DO consolidate the checkpatch changes into a single patch, then the commit message body should call out a bulleted list of all the changes you are making, as well as a justification why it is worth churning the entire file rather than just making smaller checkpatch fixes in just the areas that your other patches touch. >=20 > Actually I've made more patches in this series after I had sent the > earlier ones, > but the earlier ones are not changed at all. It's only the addition of > newer patches > to the series. The cover letter is a great place to point out how v4 differs from v3, but also to point out which patches are unchanged from v3, to save reviewer's time. So if all you did was add new patches, a cover-letter mention of which patches remain unchanged might be helpful. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Lus2fEp02vhKeNfI6F62ROvKGNBUX7uP0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXMzexAAoJEKeha0olJ0NqjlUH/jVpPNv4hzWenqYgxxQWJ/kL khgwCxS2ETGk4kON6pc8J72YpDqou5tFSto5BRWpdN+zXsnOl6GvKiEJmC7SptFj tfLsJbbvlg+0kouhvwwOTHDhbGxsKrSnqOqSWRRTmEmsu6YPtIVfHgeYmW/ie1JK /XVpKTP+SdMIK/r9TaycTx6K+75ISG7wlDapZyW12ne+UQt+Y7Jo1bxbm9TjCt/x lOKExpoqmrgAkFyjqoyefySQvgrO21lTPtFJeM7XME69EgAPQGJfQa/T/171sy44 27Ipe2HmER1CrhyAjC4AgquWmTgpPnNAJQi8ZVw99KM3HHA2FKPzy0kjU/r8t48= =4wTC -----END PGP SIGNATURE----- --Lus2fEp02vhKeNfI6F62ROvKGNBUX7uP0--