From: Dave Hansen <dave.hansen@linux.intel.com>
To: Yu-cheng Yu <yu-cheng.yu@intel.com>,
linux-kernel@vger.kernel.org, x86@kernel.org,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>
Cc: Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@suse.de>,
Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>,
"Ravi V. Shankar" <ravi.v.shankar@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>
Subject: Re: [PATCH v6 07/13] x86/xsaves: Fix PTRACE frames for XSAVES
Date: Wed, 11 May 2016 07:50:56 -0700 [thread overview]
Message-ID: <573346D0.7040508@linux.intel.com> (raw)
In-Reply-To: <33faa9b05447cd1b5bee02b1292249df7951b433.1462914897.git.yu-cheng.yu@intel.com>
On 05/10/2016 04:29 PM, Yu-cheng Yu wrote:
> XSAVES uses compacted format and is a kernel instruction. The kernel
> should use standard-format, non-supervisor state data for PTRACE.
>
> Signed-off-by: Yu-cheng Yu <yu-cheng.yu@intel.com>
This looks fine. There are a few comments that could use some sprucing
up, like:
+ /*
+ * Reject if the user sets any forbidden features.
+ */
But it's minor stuff.
Reviewed-by: Dave Hansen <dave.hansen@intel.com>
next prev parent reply other threads:[~2016-05-11 14:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 23:29 [PATCH v6 00/13] x86/xsaves: Fix XSAVES issues Yu-cheng Yu
2016-05-10 23:29 ` [PATCH v6 01/13] x86/xsaves: Define and use fpu_user_xstate_size Yu-cheng Yu
2016-05-11 17:20 ` Borislav Petkov
2016-05-11 17:25 ` Yu, Fenghua
2016-05-11 17:32 ` Borislav Petkov
2016-05-12 6:35 ` Ingo Molnar
2016-05-10 23:29 ` [PATCH v6 02/13] x86/xsaves: Rename xstate_size to fpu_kernel_xstate_size to distinguish from fpu_user_xstate_size Yu-cheng Yu
2016-05-10 23:29 ` [PATCH v6 03/13] x86/xsaves: Keep init_fpstate.xsave.header.xfeatures as zero for init optimization Yu-cheng Yu
2016-05-10 23:29 ` [PATCH v6 04/13] x86/xsaves: Introduce a new check that allows correct xstates copy from kernel to user directly Yu-cheng Yu
2016-05-10 23:29 ` [PATCH v6 05/13] x86/xsaves: Align xstate components according to CPUID Yu-cheng Yu
2016-05-10 23:29 ` [PATCH v6 06/13] x86/xsaves: Supervisor state component offset Yu-cheng Yu
2016-05-10 23:29 ` [PATCH v6 07/13] x86/xsaves: Fix PTRACE frames for XSAVES Yu-cheng Yu
2016-05-11 14:50 ` Dave Hansen [this message]
2016-05-11 15:16 ` Ingo Molnar
2016-05-10 23:30 ` [PATCH v6 08/13] x86/xsaves: Fix XSTATE component offset print out Yu-cheng Yu
2016-05-10 23:30 ` [PATCH v6 09/13] x86/xsaves: Fix xstate_offsets, xstate_sizes for non-extended states Yu-cheng Yu
2016-05-10 23:30 ` [PATCH v6 10/13] x86/xsaves: Fix __fpu_restore_sig() for XSAVES Yu-cheng Yu
2016-05-10 23:30 ` [PATCH v6 11/13] x86/xsaves: When a disabled xstate component offset is requested, return NULL Yu-cheng Yu
2016-05-10 23:30 ` [PATCH v6 12/13] x86/xsaves: Fix fpstate_init() for XRSTORS Yu-cheng Yu
2016-05-10 23:30 ` [PATCH v6 13/13] x86/xsaves: Re-enable XSAVES Yu-cheng Yu
2016-05-11 4:17 ` [PATCH v6 00/13] x86/xsaves: Fix XSAVES issues Borislav Petkov
2016-05-11 20:03 ` Yu-cheng Yu
2016-05-11 20:12 ` Borislav Petkov
2016-05-12 6:41 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573346D0.7040508@linux.intel.com \
--to=dave.hansen@linux.intel.com \
--cc=bp@suse.de \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=ravi.v.shankar@intel.com \
--cc=sai.praneeth.prakhya@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yu-cheng.yu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox