From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932266AbcEKPT2 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 11 May 2016 11:19:28 -0400
Received: from smtp.citrix.com ([66.165.176.89]:30271 "EHLO SMTP.CITRIX.COM"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751916AbcEKPTO (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 11 May 2016 11:19:14 -0400
X-IronPort-AV: E=Sophos;i="5.24,608,1454976000"; 
   d="scan'208";a="353190204"
Subject: Re: [PATCH] xen: remove incorrect forward declaration
To: Juergen Gross <jgross@suse.com>, Arnd Bergmann <arnd@arndb.de>,
        "David Vrabel" <david.vrabel@citrix.com>
References: <1462972075-918938-1-git-send-email-arnd@arndb.de>
 <57333C1D.8070405@suse.com>
CC: <stable@vger.kernel.org>, Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Daniel Kiper <daniel.kiper@oracle.com>,
        Julien Grall <julien.grall@citrix.com>,
        Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        "Paul Gortmaker" <paul.gortmaker@windriver.com>,
        <xen-devel@lists.xenproject.org>, <linux-kernel@vger.kernel.org>
From: Ross Lagerwall <ross.lagerwall@citrix.com>
Message-ID: <57334D6E.6000302@citrix.com>
Date: Wed, 11 May 2016 16:19:10 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.0
MIME-Version: 1.0
In-Reply-To: <57333C1D.8070405@suse.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-DLP: MIA2
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/11/2016 03:05 PM, Juergen Gross wrote:
> On 11/05/16 15:07, Arnd Bergmann wrote:
>> A bugfix patch for the xen balloon driver introduced a forward
>> declaration for a static function that is conditionally compiled,
>> causing a warning if only the declaration but not the definition
>> are there:
>>
>> drivers/xen/balloon.c:154:13: error: 'release_memory_resource' declared 'static' but never defined [-Werror=unused-function]
>>   static void release_memory_resource(struct resource *resource);
>>
>> This removes the declaration again and instead moves the function
>> definition to the right place, before its first caller and inside
>> of the #ifdef protecting both.
>>
>> The patch that introduced the warning is marked for stable
>> backports, so if that gets applied to 4.4, so should this one.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Fixes: dfd74a1edfab ("xen/balloon: Fix crash when ballooning on x86 32 bit PAE")
>> Cc: stable@vger.kernel.org
>
> So you've CC'ed Ross, who sent the very same patch just yesterday, but
> without the backport request.
>

Well it wasn't clear to me whether it should be the maintainer or the 
patch submitter who should request the backport and 
Documentation/SubmittingPatches is not clear about it. Regardless, the 
build fix should be backported to 4.4.

-- 
Ross Lagerwall