From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932104AbcEKRes (ORCPT ); Wed, 11 May 2016 13:34:48 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:4524 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751805AbcEKReq (ORCPT ); Wed, 11 May 2016 13:34:46 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Wed, 11 May 2016 10:33:51 -0700 Message-ID: <57336A42.3090507@nvidia.com> Date: Wed, 11 May 2016 22:52:10 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Jon Hunter , , , , CC: , , Subject: Re: [PATCH V4 3/3] soc/tegra: pmc: Add support for IO pads power state and voltage References: <1462531548-12914-1-git-send-email-ldewangan@nvidia.com> <1462531548-12914-4-git-send-email-ldewangan@nvidia.com> <572CAC20.9030307@nvidia.com> <572CB906.3090004@nvidia.com> <572F2D84.3060505@nvidia.com> <57333366.2040500@nvidia.com> <5733513E.9080606@nvidia.com> In-Reply-To: <5733513E.9080606@nvidia.com> X-Originating-IP: [10.19.65.30] X-ClientProxiedBy: DRHKMAIL101.nvidia.com (10.25.59.15) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 11 May 2016 09:05 PM, Jon Hunter wrote: > On 11/05/16 14:28, Laxman Dewangan wrote: >> On Sunday 08 May 2016 05:43 PM, Jon Hunter wrote: >>> On 06/05/16 16:32, Laxman Dewangan wrote: >>>> On Friday 06 May 2016 08:07 PM, Jon Hunter wrote: >>>>> On 06/05/16 11:45, Laxman Dewangan wrote: >>>>> + >>>>> + /* Last entry */ >>>>> + TEGRA_IO_PAD_MAX, >>>>> Nit should these be TEGRA_IO_PADS_xxx? >>>> Because this was name of single pad and hence I said TEGRA_IO_PAD_XXX. >>> Aren't these used to set the voltage level and power state for the >>> entire group of IOs? Confused :-( >> One IO pad can have multiple IO pins. >> IO Pad control the power state and voltage of all pins belongs to that >> IO pad. > Ugh ... I remember for xusb there was something similar we the Tegra > docs used pad to imply multiple. However, in general pad == pin == ball > or at least should. when we say sddmc3 IO pads, we deal with all signal pins of sdmm3.