From: Jon Hunter <jonathanh@nvidia.com>
To: Laxman Dewangan <ldewangan@nvidia.com>,
<thierry.reding@gmail.com>, <airlied@linux.ie>,
<swarren@wwwdotorg.org>, <gnurou@gmail.com>
Cc: <dri-devel@lists.freedesktop.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V4 3/3] soc/tegra: pmc: Add support for IO pads power state and voltage
Date: Wed, 11 May 2016 20:59:08 +0100 [thread overview]
Message-ID: <57338F0C.2030101@nvidia.com> (raw)
In-Reply-To: <57336A42.3090507@nvidia.com>
On 11/05/16 18:22, Laxman Dewangan wrote:
>
> On Wednesday 11 May 2016 09:05 PM, Jon Hunter wrote:
>> On 11/05/16 14:28, Laxman Dewangan wrote:
>>> On Sunday 08 May 2016 05:43 PM, Jon Hunter wrote:
>>>> On 06/05/16 16:32, Laxman Dewangan wrote:
>>>>> On Friday 06 May 2016 08:07 PM, Jon Hunter wrote:
>>>>>> On 06/05/16 11:45, Laxman Dewangan wrote:
>>>>>> +
>>>>>> + /* Last entry */
>>>>>> + TEGRA_IO_PAD_MAX,
>>>>>> Nit should these be TEGRA_IO_PADS_xxx?
>>>>> Because this was name of single pad and hence I said TEGRA_IO_PAD_XXX.
>>>> Aren't these used to set the voltage level and power state for the
>>>> entire group of IOs? Confused :-(
>>> One IO pad can have multiple IO pins.
>>> IO Pad control the power state and voltage of all pins belongs to that
>>> IO pad.
>> Ugh ... I remember for xusb there was something similar we the Tegra
>> docs used pad to imply multiple. However, in general pad == pin == ball
>> or at least should.
>
> when we say sddmc3 IO pads, we deal with all signal pins of sdmm3.
Right but now you are saying io-pads and not io-pad. Yes io-pads would
mean more than one, but IMO io-pad implies singular. Anyway, enough
bike-shedding ...
Jon
prev parent reply other threads:[~2016-05-11 19:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 10:45 [PATCH V4 0/3] soc/tegra: Add support for IO pads power and voltage control Laxman Dewangan
2016-05-06 10:45 ` [PATCH V4 1/3] soc/tegra: pmc: Use BIT macro for register field definition Laxman Dewangan
2016-05-06 14:12 ` Jon Hunter
2016-05-06 10:45 ` [PATCH V4 2/3] soc/tegra: pmc: Correct type of variable for tegra_pmc_readl() Laxman Dewangan
2016-05-06 14:15 ` Jon Hunter
2016-05-06 10:45 ` [PATCH V4 3/3] soc/tegra: pmc: Add support for IO pads power state and voltage Laxman Dewangan
2016-05-06 14:37 ` Jon Hunter
2016-05-06 15:32 ` Laxman Dewangan
2016-05-08 12:13 ` Jon Hunter
2016-05-11 13:28 ` Laxman Dewangan
2016-05-11 15:35 ` Jon Hunter
2016-05-11 17:22 ` Laxman Dewangan
2016-05-11 19:59 ` Jon Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57338F0C.2030101@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=gnurou@gmail.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).