From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752433AbcELBNw (ORCPT ); Wed, 11 May 2016 21:13:52 -0400 Received: from lucky1.263xmail.com ([211.157.147.134]:52705 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752207AbcELBNu (ORCPT ); Wed, 11 May 2016 21:13:50 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: david.wu@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: david.wu@rock-chips.com X-UNIQUE-TAG: <82cbb0de765b28738f1b2ef6d304db78> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v8 6/8] dt-bindings: i2c: rk3x: add support for rk3399 To: Doug Anderson References: <1462908252-27016-1-git-send-email-david.wu@rock-chips.com> <1462908647-27236-1-git-send-email-david.wu@rock-chips.com> Cc: =?UTF-8?Q?Heiko_St=c3=bcbner?= , Wolfram Sang , Rob Herring , Andy Shevchenko , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Brian Norris , David Riley , Tao Huang , Lin Huang , Jianqun Xu , Chris , Eddie Cai , "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Rockchip SoC..." , "linux-i2c@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: "David.Wu" Message-ID: <5733D8DC.1010603@rock-chips.com> Date: Thu, 12 May 2016 09:14:04 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Doug, 在 2016/5/12 0:35, Doug Anderson 写道: > Hi, > > On Tue, May 10, 2016 at 12:30 PM, David Wu wrote: >> The bus clock and function clock are separated at rk3399, >> and others use one clock as the bus clock and function clock. >> >> Signed-off-by: David Wu >> Reviewed-by: Douglas Anderson >> --- >> Change in v8: >> - remove error description. >> >> Documentation/devicetree/bindings/i2c/i2c-rk3x.txt | 16 +++++++++++++--- >> 1 file changed, 13 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/i2c/i2c-rk3x.txt b/Documentation/devicetree/bindings/i2c/i2c-rk3x.txt >> index 0b4a85f..5429301 100644 >> --- a/Documentation/devicetree/bindings/i2c/i2c-rk3x.txt >> +++ b/Documentation/devicetree/bindings/i2c/i2c-rk3x.txt >> @@ -6,10 +6,20 @@ RK3xxx SoCs. >> Required properties : >> >> - reg : Offset and length of the register set for the device >> - - compatible : should be "rockchip,rk3066-i2c", "rockchip,rk3188-i2c", >> - "rockchip,rk3228-i2c" or "rockchip,rk3288-i2c". >> + - compatible: should be one of the following: >> + - "rockchip,rk3066-i2c": for rk3066 >> + - "rockchip,rk3188-i2c": for rk3188 >> + - "rockchip,rk3228-i2c": for rk3228 >> + - "rockchip,rk3288-i2c": for rk3288 >> + - "rockchip,rk3399-i2c": for rk3399 >> - interrupts : interrupt number >> - - clocks : parent clock >> + - clocks: See ../clock/clock-bindings.txt >> + - For older hardware (rk3066, rk3188, rk3228, rk3288): >> + - There is one clock that's used both to derive the functional clock >> + for the device and as the bus clock. >> + - For newer hardware (rk3399): specified by name >> + - "i2c": REQUIRED. This is used to derive the functional clock. >> + - "pclk": REQUIRED. This is the bus clock. > > Depending on what Rob thinks, it might make sense to remove the above > two "REQUIRED" bits. That would match his earlier feedback since > we're still in the "Required" section and thus it is redundant. > Okay, i make a little misunderstand for that, so i will fix it in next version. > -Doug > > >