From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932304AbcELK1A (ORCPT ); Thu, 12 May 2016 06:27:00 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:38915 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751105AbcELK0j (ORCPT ); Thu, 12 May 2016 06:26:39 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfee691-f79196d000001483-ee-57345a5c1429 Content-transfer-encoding: 8BIT Message-id: <57345A5C.2080607@samsung.com> Date: Thu, 12 May 2016 19:26:36 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Rob Herring Cc: sre@kernel.org, dbaryshkov@gmail.com, dwmw2@infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 0/3] power: Remove the deprecated extcon functions References: <1461232535-3959-1-git-send-email-cw00.choi@samsung.com> <57313162.20208@samsung.com> <20160511134706.GA8753@rob-hp-laptop> In-reply-to: <20160511134706.GA8753@rob-hp-laptop> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprJIsWRmVeSWpSXmKPExsWyRsSkRDcmyiTcYP1+Y4tJT94zW8w/co7V YuLKycwWl3fNYbP43HuE0eL/nh3sFqd3lziwe+ycdZfdY/MKLY9NqzrZPD5vkgtgieKySUnN ySxLLdK3S+DKmHTmPkvBK7mK3m2LGBsY90l0MXJySAiYSGx4sI0ZwhaTuHBvPVsXIxeHkMAK RomDDa0sMEUPjx5jgkgsZZTYfvMjE0iCV0BQ4sfke0BFHBzMAvISRy5lQ5jqElOm5EKUP2CU eHrmFhtEuZbEgv6brCA2i4CqxOqfuxhBbDag+P4XN9hAekUFIiS6T1SChEUEFCV+t00DK2cW mMoocXxbDogtLOAp0fd+AyvE/E5GidPNO9lBEpwCRhLP775mB0lICJxil/iy5h0jxDIBiW+T D4HdKSEgK7HpANTDkhIHV9xgmcAoNgvJN7MQvpmF8M0CRuZVjKKpBckFxUnpRaZ6xYm5xaV5 6XrJ+bmbGIExdvrfs4k7GO8fsD7EKMDBqMTD6/HQOFyINbGsuDL3EKMp0A0TmaVEk/OBkZxX Em9obGZkYWpiamxkbmmmJM6rI/0zWEggPbEkNTs1tSC1KL6oNCe1+BAjEwenVANjq4+Lt+Eb fZGOG59LPbw2n7gouFz0km+V0wyRrrI8rbqJ1+8ccTx5R15lisaCgnXWc9ZtZTl+tG+LhHzu phmhj4qTGcvN3M5fvphTtXzzx6iF07lX8218MOmPsEtub1iI+Y27RpP3LNLtO/RSf5XjPHW/ TkYDj0COkuhNpxIOa77z9M+v4N2qxFKckWioxVxUnAgAl13zt6wCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrGIsWRmVeSWpSXmKPExsVy+t9jAd2YKJNwg44fOhaTnrxntph/5Byr xcSVk5ktLu+aw2bxufcIo8X/PTvYLU7vLnFg99g56y67x+YVWh6bVnWyeXzeJBfAEtXAaJOR mpiSWqSQmpecn5KZl26r5B0c7xxvamZgqGtoaWGupJCXmJtqq+TiE6DrlpkDdICSQlliTilQ KCCxuFhJ3w7ThNAQN10LmMYIXd+QILgeIwM0kLCGMWPSmfssBa/kKnq3LWJsYNwn0cXIySEh YCLx8OgxJghbTOLCvfVsXYxcHEICSxkltt/8CJbgFRCU+DH5HksXIwcHs4C8xJFL2RCmusSU KbkQ5Q8YJZ6eucUGUa4lsaD/JiuIzSKgKrH65y5GEJsNKL7/xQ02kF5RgQiJ7hOVIGERAUWJ 323TwMqZBaYyShzflgNiCwt4SvS938AKMb+TUeJ08052kASngJHE87uv2ScwCsxCct0shOtm IVy3gJF5FaNEakFyQXFSeq5hXmq5XnFibnFpXrpecn7uJkZwHD+T2sF4cJf7IUYBDkYlHl6P h8bhQqyJZcWVuYcYJTiYlUR49SNNwoV4UxIrq1KL8uOLSnNSiw8xmgK9N5FZSjQ5H5hi8kri DY1NzIwsjcwNLYyMzZXEeR//XxcmJJCeWJKanZpakFoE08fEwSnVwLhJxDNl9TL1iJp/BXff zWk7bbwzW425M30D31FHT/v/++Jcvz4S3y5vdCNQrvuNmMWTlZ+X7JvKtKq1SbB/rdP72WvF ixtltxpI3Sxn+5HXo7cmZNZ9m/mzD7ZIOjCHSrw7uMbuEW8C35533zeG9K98dHTbart97Jm6 +l1hbr/EA52O/Q3JkldiKc5INNRiLipOBAAQg/0X+QIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, On 2016년 05월 11일 22:47, Rob Herring wrote: > On Tue, May 10, 2016 at 09:54:58AM +0900, Chanwoo Choi wrote: >> Ping. >> >> Could you review this patch? > > I already did. The first problem is you are breaking compatibility here > (a kernel with these changes won't work with a dtb without these > changes). As I previously said, this binding in general is horribly > designed and full on Linux driver specifics. The first clue is your > driver changes are resulting in DT changes. If you are going to break > compatibility here, it better be redoing this binding. The problems I > see with this binding are: > > - Linux device name strings > - "charger-manager" is not a chip or circuit. DT describes the h/w. > - Current limits by type of USB connection are pointless. These are part > of the spec. > - Properties need standard unit suffixes. > - A mixture of battery and charger properties. As I mentioned already on previous reply, I agree about your opinion absolutely. The current charger-manager is not proper DT binding as you mentioned. Just I want to remove the deprecated EXTCON API on charger-manager. I don't have any thinking about improving the charger-manager driver. As you mentioned, "charger-manager" is not a chip or circuit. So, I think that new charging framework should be implemented on power-supply framework with deleting charger-manager driver. But, the update to change the "charger-manager" dt binding style may be huge task. I think that we have to divide this task from removing the deprecated EXTCON API. Dear Sebastian, If possible, I'd like to receive the opinion from you. Regards, Chanwoo Choi > >> >> Thanks, >> Chanwoo Choi >> >> On 2016년 04월 21일 18:55, Chanwoo Choi wrote: >>> This patch-set removes the deprecated notifier API of extcon framework and >>> then use the new extcon API[2] with the unique id[1] to indicate the each >>> external connector. Alter deprecated API as following: >>> - extcon_register_interest() -> extcon_register_notifier() >>> - extcon_unregister_interest() -> extcon_unregister_notifier() >>> - extcon_set_cable_state() -> extcon_set_cable_state_() >>> - extcon_get_cable_state() -> extcon_get_cable_state_() >>> >>> And, extcon alters the name of USB charger connector in patch[3] as following: >>> - EXTCON_CHG_USB_SDP /* Standard Downstream Port */ >>> - EXTCON_CHG_USB_DCP /* Dedicated Charging Port */ >>> - EXTCON_CHG_USB_CDP /* Charging Downstream Port */ >>> - EXTCON_CHG_USB_ACA /* Accessory Charger Adapter */ >>> >>> [1] Commit 2a9de9c0f08d61 >>> - ("extcon: Use the unique id for external connector instead of string) >>> [2] Commit 046050f6e623e4 >>> - ("extcon: Update the prototype of extcon_register_notifier() with enum extcon >>> [3] Commit 11eecf910bd81d >>> - ("extcon: Modify the id and name of external connector") >>> >>> Changes from v1: >>> - Fix the typo (EXTCON_CHG_USB_SDP -> EXTCON_CHG_USB_CDP) on axp288_charger.c >>> >>> Chanwoo Choi (3): >>> power: charger-manager: Replace deprecatd API of extcon >>> power: axp288_charger: Replace deprecatd API of extcon >>> extcon: Remove the deprecated extcon functions >>> >>> .../bindings/power_supply/charger-manager.txt | 4 +- >>> drivers/extcon/extcon.c | 201 +++------------------ >>> drivers/power/axp288_charger.c | 77 +++++--- >>> drivers/power/charger-manager.c | 31 ++-- >>> include/linux/extcon.h | 59 ------ >>> include/linux/power/charger-manager.h | 4 +- >>> 6 files changed, 101 insertions(+), 275 deletions(-) >>> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe devicetree" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > >