From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932226AbcELKap (ORCPT ); Thu, 12 May 2016 06:30:45 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:8916 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752455AbcELKam (ORCPT ); Thu, 12 May 2016 06:30:42 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Thu, 12 May 2016 03:28:58 -0700 Subject: Re: [PATCH 6/6] pinctrl: tegra: Add driver to configure voltage and power state of io pads To: Stephen Warren , Linus Walleij , Laxman Dewangan References: <1462191434-28933-1-git-send-email-ldewangan@nvidia.com> <1462191434-28933-7-git-send-email-ldewangan@nvidia.com> <573358A8.2060509@wwwdotorg.org> CC: Alexandre Courbot , Rob Herring , Mark Rutland , Thierry Reding , "linux-tegra@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" X-Nvconfidentiality: public From: Jon Hunter Message-ID: <57345B4A.8020409@nvidia.com> Date: Thu, 12 May 2016 11:30:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <573358A8.2060509@wwwdotorg.org> X-Originating-IP: [10.21.132.102] X-ClientProxiedBy: UKMAIL102.nvidia.com (10.26.138.15) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/05/16 17:07, Stephen Warren wrote: > On 05/11/2016 03:19 AM, Linus Walleij wrote: >> On Mon, May 2, 2016 at 2:17 PM, Laxman Dewangan >> wrote: >> >>> NVIDIA Tegra210 supports the IO pads which can operate at 1.8V >>> or 3.3V I/O voltage levels. Also the IO pads can be configured >>> for power down state if it is not used. SW needs to configure the >>> voltage level of IO pads based on IO rail voltage and its power >>> state based on platform usage. >>> >>> The voltage and power state configurations of pads are provided >>> through pin control frameworks. Add pin control driver for Tegra's >>> IO pads' voltage and power state configurations. >>> >>> Signed-off-by: Laxman Dewangan >>> >>> --- >>> Changes from V1: >>> - Use the generic pincontrol property for low power enable/disable. >>> - sync with latest and remove all MODULE* macros >>> - Use renamed APIs form PMC >> >> Looks OK to me, need Stephen's ACK though! > > This driver is for HW that's separate from the main Tegra pinmux module. > Thierry Reding and Jon Hunter are more appropriate reviewers for this one. There will be another spin of this, so let's wait for the V2. Cheers Jon