From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752588AbcELLna (ORCPT <rfc822;w@1wt.eu>);
	Thu, 12 May 2016 07:43:30 -0400
Received: from szxga02-in.huawei.com ([119.145.14.65]:44419 "EHLO
	szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752083AbcELLn3 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 12 May 2016 07:43:29 -0400
Subject: Re: [PATCH] genirq: export __irq_set_affinity symbol
To: Thomas Gleixner <tglx@linutronix.de>, <hch@infradead.org>
References: <1463032287-21692-1-git-send-email-xiexiuqi@huawei.com>
 <alpine.DEB.2.11.1605120942020.3911@nanos>
CC: <linux-kernel@vger.kernel.org>, <huawei.libin@huawei.com>,
        <wangyijing@huawei.com>
From: Xie XiuQi <xiexiuqi@huawei.com>
Message-ID: <57346C0D.8020706@huawei.com>
Date: Thu, 12 May 2016 19:42:05 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.11.1605120942020.3911@nanos>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.177.19.210]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A090204.57346C1C.018D,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-06-18 04:22:30,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: cfa54ffc65884e6f4a4b380a9a389a02
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2016/5/12 15:43, Thomas Gleixner wrote:
> On Thu, 12 May 2016, Xie XiuQi wrote:
> 
>> __irq_set_affinity is declared in include/linux/interrupt.h, but not
>> been exported.
>>
>> We export it now, so we could use __irq_set_affinity, irq_set_affinity
>> and irq_force_affinity in kernel modules.
> 
> Please show the code using the exports first. We don't export symbols w/o
> knowing the usecase.

The default affinity of the interrupts for all devices is always CPU0,
this may cause the latency on CPU0 is very high when some interrupt
occurs very frequently.

I want to migrate an interrupt to another cpu when the driver loading.

My code like this:

/* I want to bind irq_vector to cpu 3 */
...
cpumask_var_t mask;
cpumask_set_cpu(3, mask);
irq_set_affinity(irq_vector, mask);
...

build wanring:
WARNING: "__irq_set_affinity" [/root/drivers/dr.ko] undefined!

insmod error:
dr: Unknown symbol __irq_set_affinity (err 0)

Thanks,
Xie XiuQi

> 
> Thanks,
> 
> 	tglx
> 
>