From: Harvey Hunt <harvey.hunt@imgtec.com>
To: David Miller <davem@davemloft.net>
Cc: <robert.jarzmik@free.fr>, <Baohua.Song@csr.com>,
<marcel@ziswiler.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] drivers: net: Don't print unpopulated net_device name
Date: Thu, 12 May 2016 14:27:10 +0100 [thread overview]
Message-ID: <573484AE.2040507@imgtec.com> (raw)
In-Reply-To: <20160511.192631.759104843385712307.davem@davemloft.net>
Hi David,
On 12/05/16 00:26, David Miller wrote:
> From: Harvey Hunt <harvey.hunt@imgtec.com>
> Date: Tue, 10 May 2016 17:43:21 +0100
>
>> @@ -1686,8 +1686,7 @@ dm9000_probe(struct platform_device *pdev)
>> }
>>
>> if (!is_valid_ether_addr(ndev->dev_addr)) {
>> - dev_warn(db->dev, "%s: Invalid ethernet MAC address. Please "
>> - "set using ifconfig\n", ndev->name);
>> + dev_warn(db->dev, "Invalid ethernet MAC address. Please set using ifconfig\n");
>>
>> eth_hw_addr_random(ndev);
>> mac_src = "random";
>
> If we don't print the netdev name, it's harder for the user to see which
> adapter has the problem.
>
> Therefore, it is better if you save some boolean state into a local variable
> here, then print the warning right after register_netdev().
>
> Likewise for the rest of your changes too.
>
Okay, I'll do that for v2.
Thanks,
Harvey
prev parent reply other threads:[~2016-05-12 13:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 16:43 [PATCH net] drivers: net: Don't print unpopulated net_device name Harvey Hunt
2016-05-10 18:31 ` Stephen Hemminger
2016-05-12 13:27 ` Harvey Hunt
2016-05-11 23:26 ` David Miller
2016-05-12 13:27 ` Harvey Hunt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573484AE.2040507@imgtec.com \
--to=harvey.hunt@imgtec.com \
--cc=Baohua.Song@csr.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@ziswiler.com \
--cc=netdev@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox