From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753079AbcELN1y (ORCPT ); Thu, 12 May 2016 09:27:54 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:6745 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751912AbcELN1x (ORCPT ); Thu, 12 May 2016 09:27:53 -0400 Subject: Re: [PATCH net] drivers: net: Don't print unpopulated net_device name To: Stephen Hemminger References: <1462898601-5429-1-git-send-email-harvey.hunt@imgtec.com> <20160510113148.4b4d0d6d@xeon-e3> CC: , Robert Jarzmik , Barry Song , Marcel Ziswiler , , From: Harvey Hunt Message-ID: <573484D6.1080500@imgtec.com> Date: Thu, 12 May 2016 14:27:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20160510113148.4b4d0d6d@xeon-e3> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.26] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stephen, On 10/05/16 19:31, Stephen Hemminger wrote: > On Tue, 10 May 2016 17:43:21 +0100 > Harvey Hunt wrote: > >> For ethernet devices, net_device.name will be eth%d before >> register_netdev() is called. Don't print the net_device name until >> the format string is replaced. >> >> Cc: Robert Jarzmik >> Cc: Barry Song >> Cc: Marcel Ziswiler >> Cc: netdev@vger.kernel.org >> Cc: linux-kernel@vger.kernel.org >> >> Signed-off-by: Harvey Hunt >> --- >> I've tested this patch on a board that has a DM9000, but haven't >> tested the other two network devices. >> >> drivers/net/ethernet/davicom/dm9000.c | 3 +-- >> drivers/net/ethernet/micrel/ks8695net.c | 3 +-- >> drivers/net/ethernet/netx-eth.c | 3 +-- >> 3 files changed, 3 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/net/ethernet/davicom/dm9000.c b/drivers/net/ethernet/davicom/dm9000.c >> index 48d9194..89dcaa1 100644 >> --- a/drivers/net/ethernet/davicom/dm9000.c >> +++ b/drivers/net/ethernet/davicom/dm9000.c >> @@ -1686,8 +1686,7 @@ dm9000_probe(struct platform_device *pdev) >> } >> >> if (!is_valid_ether_addr(ndev->dev_addr)) { >> - dev_warn(db->dev, "%s: Invalid ethernet MAC address. Please " >> - "set using ifconfig\n", ndev->name); >> + dev_warn(db->dev, "Invalid ethernet MAC address. Please set using ifconfig\n"); > > ifconfig is deprecated, therefore please don't tell users to use it. > I'll update it to print "Please set using ip". Thanks, Harvey