From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752765AbcELSD6 (ORCPT ); Thu, 12 May 2016 14:03:58 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:19724 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752693AbcELSD4 (ORCPT ); Thu, 12 May 2016 14:03:56 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Thu, 12 May 2016 11:02:07 -0700 Message-ID: <5734C2C2.2060207@nvidia.com> Date: Thu, 12 May 2016 23:22:02 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Rhyland Klein , Lee Jones CC: , Subject: Re: [PATCH] mfd: max77620: Fix FPS switch statements References: <1463075104-26924-1-git-send-email-rklein@nvidia.com> In-Reply-To: <1463075104-26924-1-git-send-email-rklein@nvidia.com> X-Originating-IP: [10.19.65.30] X-ClientProxiedBy: BGMAIL101.nvidia.com (10.25.59.10) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 12 May 2016 11:15 PM, Rhyland Klein wrote: > When configuring FPS during probe, assuming a DT node is present for > FPS, the code can run into a problem with the switch statements in > max77620_config_fps() and max77620_get_fps_period_reg_value(). Namely, > in the case of chip->chip_id == MAX77620, it will set > fps_[mix|max]_period but then fall through to the default switch case > and return -EINVAL. Returning this from max77620_config_fps() will > cause probe to fail. > Thanks for fixes. Missed when converting if-else to switch. Reviewed-by: Laxman Dewangan