From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751489AbcELUXl (ORCPT ); Thu, 12 May 2016 16:23:41 -0400 Received: from mail-io0-f193.google.com ([209.85.223.193]:33086 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750907AbcELUXj (ORCPT ); Thu, 12 May 2016 16:23:39 -0400 Subject: Re: [PATCH v3 3/7] perf tools: Remove the logical that skip buildid cache if symfs is given To: Arnaldo Carvalho de Melo References: <1463042596-61703-1-git-send-email-hekuang@huawei.com> <1463042596-61703-4-git-send-email-hekuang@huawei.com> <20160512130925.GG20258@kernel.org> Cc: He Kuang , peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, jolsa@redhat.com, wangnan0@huawei.com, jpoimboe@redhat.com, ak@linux.intel.com, eranian@google.com, namhyung@kernel.org, adrian.hunter@intel.com, sukadev@linux.vnet.ibm.com, masami.hiramatsu.pt@hitachi.com, tumanova@linux.vnet.ibm.com, kan.liang@intel.com, penberg@kernel.org, linux-kernel@vger.kernel.org From: David Ahern Message-ID: <5734E649.80505@gmail.com> Date: Thu, 12 May 2016 14:23:37 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20160512130925.GG20258@kernel.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/12/16 7:09 AM, Arnaldo Carvalho de Melo wrote: > Em Thu, May 12, 2016 at 08:43:12AM +0000, He Kuang escreveu: >> Symfs dir and buildid dir are two places that perf looks into for >> symbols, currently, if symfs dir is given, buildid-cache is skipped. >> >> In the cross-platform perf record/script scenario, we need vdsos in >> buildid-cache dir and other libs in symfs dir at the same time. And >> consider that the binaries indexed by buildid do not cause ambiguity, >> this patch simply removes that logical. > > Makes perfect sense, David, do you have any concern? Can I have your > Acked-by? seems odd to me you want to look in the buildid-cache when a symfs is given. The point of symfs was "go look for everything under here." I believe dso__load is going to hit DSO_BINARY_TYPE__BUILD_ID_CACHE before any of the others and there are probably cases where a stale cache entry would be hit before a build tree entry (e.g., symfs). What about putting the build id cache under the symfs? so instead of dropping the symfs check and it to the path for the build id cache.