From: Keerthy <a0393675@ti.com>
To: Lee Jones <lee.jones@linaro.org>, Keerthy <j-keerthy@ti.com>
Cc: <broonie@kernel.org>, <lgirdwood@gmail.com>,
<linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>,
<devicetree@vger.kernel.org>, <robh+dt@kernel.org>,
<mark.rutland@arm.com>
Subject: Re: [PATCH v2 1/3] Documentation: mfd: LP873X: Add information for the mfd and regulator drivers
Date: Fri, 13 May 2016 04:51:34 +0530 [thread overview]
Message-ID: <57350FFE.9030903@ti.com> (raw)
In-Reply-To: <20160512132140.GC1433@dell.open.watershed.co.uk>
On Thursday 12 May 2016 06:51 PM, Lee Jones wrote:
> On Tue, 10 May 2016, Keerthy wrote:
>
>> Add information for the mfd and regulator drivers.
>>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>> ---
>> Documentation/devicetree/bindings/mfd/lp873x.txt | 55 ++++++++++++++++++++++++
>> 1 file changed, 55 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/mfd/lp873x.txt
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/lp873x.txt b/Documentation/devicetree/bindings/mfd/lp873x.txt
>> new file mode 100644
>> index 0000000..3ef5ea0
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mfd/lp873x.txt
>> @@ -0,0 +1,55 @@
>> +TI LP3943 MFD driver
>> +
>> +Required properties:
>> + - compatible: "ti,lp8732", "ti,lp8733"
>> + - reg: I2C slave address.
>> +
>> +For the lp873x regulator properties please refer to:
>> +Documentation/devicetree/bindings/regulator/lp873x.txt
>
> This is a Linuxism. Use ../bindings/.. instead.
Okay.
>
>> +Example:
>> +
>> +lp8733: lp8733@60 {
>
> lp8733 is not a device 'type'. What does it do?
>
> Looks like a 'pmic' to me.
>
>> + compatible = "ti,lp8733";
>> + reg = <0x60>;
>> +
>> + regulators {
>> + lp8733_buck0: buck0 {
>> + regulator-name = "lp8733-buck0";
>> + regulator-min-microvolt = <800000>;
>> + regulator-max-microvolt = <1400000>;
>> + regulator-min-microamp = <1500000>;
>> + regulator-max-microamp = <4000000>;
>> + regulator-ramp-delay = <10000>;
>> + regulator-always-on;
>> + regulator-boot-on;
>> + };
>> +
>> + lp8733_buck1: buck1 {
>> + regulator-name = "lp8733-buck1";
>> + regulator-min-microvolt = <800000>;
>> + regulator-max-microvolt = <1400000>;
>> + regulator-min-microamp = <1500000>;
>> + regulator-max-microamp = <4000000>;
>> + regulator-ramp-delay = <10000>;
>> + regulator-boot-on;
>> + regulator-always-on;
>> + };
>> +
>> + lp8733_ldo0: ldo0 {
>> + regulator-name = "lp8733-ldo0";
>> + regulator-min-microvolt = <800000>;
>> + regulator-max-microvolt = <3000000>;
>> + regulator-boot-on;
>> + regulator-always-on;
>> + };
>> +
>> + lp8733_ldo1: ldo1 {
>> + regulator-name = "lp8733-ldo1";
>> + regulator-min-microvolt = <800000>;
>> + regulator-max-microvolt = <3000000>;
>> + regulator-always-on;
>> + regulator-boot-on;
>> + };
>> + };
>> +};
>
> I'm failing to see how this is an MFD?
As of now, only regulators part is supported, there are Configurable
General Purpose Output Signals (GPO), Over-Temperature Warning and
Protection apart from regulators.
>
next prev parent reply other threads:[~2016-05-12 23:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 4:04 [PATCH v2 0/3] mfd: lp873x: Add lp873x PMIC support Keerthy
2016-05-10 4:04 ` [PATCH v2 1/3] Documentation: mfd: LP873X: Add information for the mfd and regulator drivers Keerthy
2016-05-11 14:35 ` Rob Herring
2016-05-12 13:21 ` Lee Jones
2016-05-12 23:21 ` Keerthy [this message]
2016-05-10 4:04 ` [PATCH v2 2/3] mfd: lp873x: Add lp873x PMIC support Keerthy
2016-05-12 13:18 ` Lee Jones
2016-05-12 23:13 ` Keerthy
2016-05-17 8:01 ` Lee Jones
2016-05-17 8:04 ` Keerthy
2016-05-17 8:07 ` Keerthy
2016-05-10 4:04 ` [PATCH v2 3/3] regulator: lp873x: Add support for lp873x PMIC regulators Keerthy
2016-05-11 17:27 ` Applied "regulator: lp873x: Add support for lp873x PMIC regulators" to the regulator tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57350FFE.9030903@ti.com \
--to=a0393675@ti.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j-keerthy@ti.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox