From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753036AbcELXVt (ORCPT ); Thu, 12 May 2016 19:21:49 -0400 Received: from arroyo.ext.ti.com ([198.47.19.12]:59384 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751958AbcELXVr (ORCPT ); Thu, 12 May 2016 19:21:47 -0400 Subject: Re: [PATCH v2 1/3] Documentation: mfd: LP873X: Add information for the mfd and regulator drivers To: Lee Jones , Keerthy References: <1462853079-10708-1-git-send-email-j-keerthy@ti.com> <1462853079-10708-2-git-send-email-j-keerthy@ti.com> <20160512132140.GC1433@dell.open.watershed.co.uk> CC: , , , , , , From: Keerthy Message-ID: <57350FFE.9030903@ti.com> Date: Fri, 13 May 2016 04:51:34 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20160512132140.GC1433@dell.open.watershed.co.uk> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 12 May 2016 06:51 PM, Lee Jones wrote: > On Tue, 10 May 2016, Keerthy wrote: > >> Add information for the mfd and regulator drivers. >> >> Signed-off-by: Keerthy >> --- >> Documentation/devicetree/bindings/mfd/lp873x.txt | 55 ++++++++++++++++++++++++ >> 1 file changed, 55 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mfd/lp873x.txt >> >> diff --git a/Documentation/devicetree/bindings/mfd/lp873x.txt b/Documentation/devicetree/bindings/mfd/lp873x.txt >> new file mode 100644 >> index 0000000..3ef5ea0 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mfd/lp873x.txt >> @@ -0,0 +1,55 @@ >> +TI LP3943 MFD driver >> + >> +Required properties: >> + - compatible: "ti,lp8732", "ti,lp8733" >> + - reg: I2C slave address. >> + >> +For the lp873x regulator properties please refer to: >> +Documentation/devicetree/bindings/regulator/lp873x.txt > > This is a Linuxism. Use ../bindings/.. instead. Okay. > >> +Example: >> + >> +lp8733: lp8733@60 { > > lp8733 is not a device 'type'. What does it do? > > Looks like a 'pmic' to me. > >> + compatible = "ti,lp8733"; >> + reg = <0x60>; >> + >> + regulators { >> + lp8733_buck0: buck0 { >> + regulator-name = "lp8733-buck0"; >> + regulator-min-microvolt = <800000>; >> + regulator-max-microvolt = <1400000>; >> + regulator-min-microamp = <1500000>; >> + regulator-max-microamp = <4000000>; >> + regulator-ramp-delay = <10000>; >> + regulator-always-on; >> + regulator-boot-on; >> + }; >> + >> + lp8733_buck1: buck1 { >> + regulator-name = "lp8733-buck1"; >> + regulator-min-microvolt = <800000>; >> + regulator-max-microvolt = <1400000>; >> + regulator-min-microamp = <1500000>; >> + regulator-max-microamp = <4000000>; >> + regulator-ramp-delay = <10000>; >> + regulator-boot-on; >> + regulator-always-on; >> + }; >> + >> + lp8733_ldo0: ldo0 { >> + regulator-name = "lp8733-ldo0"; >> + regulator-min-microvolt = <800000>; >> + regulator-max-microvolt = <3000000>; >> + regulator-boot-on; >> + regulator-always-on; >> + }; >> + >> + lp8733_ldo1: ldo1 { >> + regulator-name = "lp8733-ldo1"; >> + regulator-min-microvolt = <800000>; >> + regulator-max-microvolt = <3000000>; >> + regulator-always-on; >> + regulator-boot-on; >> + }; >> + }; >> +}; > > I'm failing to see how this is an MFD? As of now, only regulators part is supported, there are Configurable General Purpose Output Signals (GPO), Over-Temperature Warning and Protection apart from regulators. >