From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Ray Jui <ray.jui@broadcom.com>, Jon Mason <jon.mason@broadcom.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] arm64: dts: NS2: Add all of the UARTs
Date: Fri, 13 May 2016 09:17:02 +0800 [thread overview]
Message-ID: <57352B0E.5070803@huawei.com> (raw)
In-Reply-To: <befabac6-aae2-fb3b-2faa-5463b7287b2a@broadcom.com>
On 2016/5/13 0:52, Ray Jui wrote:
> Hi Kefeng,
>
> On 5/12/2016 7:46 AM, Jon Mason wrote:
>>
>>
>> On Thu, May 12, 2016 at 2:16 AM, Kefeng Wang <wangkefeng.wang@huawei.com
>> <mailto:wangkefeng.wang@huawei.com>> wrote:
>>
>>
>>
>> On 2016/5/12 6:56, Jon Mason wrote:
>> > Add all of the UARTs present on NS2 and enable them in the SVK device
>> > tree file. Also, do some magic to make sure that uart3 is discovered as
>> > ttyS0 (as that is the console UART).
>> >
>> > Signed-off-by: Jon Mason <jonmason@broadcom.com <mailto:jonmason@broadcom.com>>
>> > ---
>> > arch/arm64/boot/dts/broadcom/ns2-svk.dts | 16 ++++++++++++++++
>> > arch/arm64/boot/dts/broadcom/ns2.dtsi | 30 ++++++++++++++++++++++++++++++
>> > 2 files changed, 46 insertions(+)
>> >
>> > diff --git a/arch/arm64/boot/dts/broadcom/ns2-svk.dts b/arch/arm64/boot/dts/broadcom/ns2-svk.dts
>> > index 7cd3640..b062a44 100644
>> > --- a/arch/arm64/boot/dts/broadcom/ns2-svk.dts
>> > +++ b/arch/arm64/boot/dts/broadcom/ns2-svk.dts
>> > @@ -40,10 +40,14 @@
>> >
>> > aliases {
>> > serial0 = &uart3;
>> > + serial1 = &uart0;
>> > + serial2 = &uart1;
>> > + serial3 = &uart2;
>> > };
>> >
>> > chosen {
>> > stdout-path = "serial0:115200n8";
>> > + bootargs = "earlycon=uart8250,mmio32,0x66130000";
>>
>> Hi Jon,
>>
>> I submit a patch[1], with it, we can use earlycon without option to
>> enable early console
>> for "snps,dw-apb-uart", could you help me to test it, thanks.
>>
>>
>> Adding your change and removing the line above does not cause earlycon
>> to work for me. Is there any additional changes necessary for this to work?
>>
>> Thanks,
>> Jon
>>
>
> "OF_EARLYCON_DECLARE" doesn't seem to have a way to deal with DT properties? In the case of UART for NS2, it needs mmio32, configured with DT property "reg-io-width" set to 4. I don't think "OF_EARLYCON_DECLARE" is parsing that, which is likely the reason why it doesn't work for devices that required mmio32.
>
It should work, I test this in Hisi D02 board, it uses same uart and same configuration.
early_init_dt_scan_chosen_serial()
for (match = __earlycon_table; match < __earlycon_table_end; match++)
......
of_setup_earlycon()
val = of_get_flat_dt_prop(node, "reg-io-width", NULL); // will obtain the reg-io-width and set iotype=mmio32
err = match->setup(&early_console_dev, options); // call early_serial8250_setup
Could you check it again, thanks,
Kefeng
> Thanks,
>
> Ray
>
> .
>
next prev parent reply other threads:[~2016-05-13 1:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 22:56 [PATCH 1/2] arm64: dts: NS2: Add all of the UARTs Jon Mason
2016-05-11 22:56 ` [PATCH 2/2] arm64: dts: NS2: Add CCI-400 PMU support Jon Mason
2016-05-20 18:45 ` Florian Fainelli
2016-05-12 6:16 ` [PATCH 1/2] arm64: dts: NS2: Add all of the UARTs Kefeng Wang
[not found] ` <CAC3K-4qbkt3DCgd6qurNo3V+++x70bbFC--aunR0DbCTBvBNZg@mail.gmail.com>
2016-05-12 16:52 ` Ray Jui
2016-05-13 1:17 ` Kefeng Wang [this message]
2016-05-13 2:09 ` Kefeng Wang
[not found] ` <CAC3K-4oXcwR--879sCFR=MCG1Uman7DoGvaHLVXWr+0QH2WeJg@mail.gmail.com>
2016-05-16 1:11 ` Kefeng Wang
2016-05-17 19:56 ` Florian Fainelli
2016-05-18 5:50 ` Kefeng Wang
2016-05-20 18:45 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57352B0E.5070803@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jon.mason@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=ray.jui@broadcom.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).