From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753125AbcEMCLP (ORCPT ); Thu, 12 May 2016 22:11:15 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:45251 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751706AbcEMCLO (ORCPT ); Thu, 12 May 2016 22:11:14 -0400 Subject: Re: [PATCH 1/2] arm64: dts: NS2: Add all of the UARTs To: Jon Mason References: <1463007369-13071-1-git-send-email-jonmason@broadcom.com> <57341FCE.6050403@huawei.com> CC: Florian Fainelli , Ray Jui , Scott Branden , Rob Herring , Pawel Moll , Mark Rutland , "Ian Campbell" , Kumar Gala , Catalin Marinas , Will Deacon , BCM Kernel Feedback , , , From: Kefeng Wang Message-ID: <57353761.5020409@huawei.com> Date: Fri, 13 May 2016 10:09:37 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.19.180] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020202.573537AC.006E,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 856826df7b0f7b2c213e032323e2fd43 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/5/12 22:46, Jon Mason wrote: > > > On Thu, May 12, 2016 at 2:16 AM, Kefeng Wang > wrote: > > > > On 2016/5/12 6:56, Jon Mason wrote: > > Add all of the UARTs present on NS2 and enable them in the SVK device > > tree file. Also, do some magic to make sure that uart3 is discovered as > > ttyS0 (as that is the console UART). > > > > Signed-off-by: Jon Mason > > > --- > > arch/arm64/boot/dts/broadcom/ns2-svk.dts | 16 ++++++++++++++++ > > arch/arm64/boot/dts/broadcom/ns2.dtsi | 30 ++++++++++++++++++++++++++++++ > > 2 files changed, 46 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/broadcom/ns2-svk.dts b/arch/arm64/boot/dts/broadcom/ns2-svk.dts > > index 7cd3640..b062a44 100644 > > --- a/arch/arm64/boot/dts/broadcom/ns2-svk.dts > > +++ b/arch/arm64/boot/dts/broadcom/ns2-svk.dts > > @@ -40,10 +40,14 @@ > > > > aliases { > > serial0 = &uart3; > > + serial1 = &uart0; > > + serial2 = &uart1; > > + serial3 = &uart2; > > }; > > > > chosen { > > stdout-path = "serial0:115200n8"; > > + bootargs = "earlycon=uart8250,mmio32,0x66130000"; > > Hi Jon, > > I submit a patch[1], with it, we can use earlycon without option to enable early console > for "snps,dw-apb-uart", could you help me to test it, thanks. > > > Adding your change and removing the line above does not cause earlycon to work for me. Is there any additional changes necessary for this to work? With my patch, the bootargs still need contain earlycon, but no need uart8250,mmio32,0x66130000; chosen { stdout-path = "serial0:115200n8"; bootargs = "earlycon"; } Hope it would work. BRs, Kefeng > > Thanks, > Jon > > > > BRs, > Kefeng > > > [1] https://lkml.org/lkml/2016/5/11/34 > > > }; > > > > memory { > > @@ -68,6 +72,18 @@ > > status = "ok"; > > }; > > > > +&uart0 { > > + status = "ok"; > > +}; > > + > > +&uart1 { > > + status = "ok"; > > +}; > > + > > +&uart2 { > > + status = "ok"; > > +}; > > + > > &uart3 { > > status = "ok"; > > }; > > diff --git a/arch/arm64/boot/dts/broadcom/ns2.dtsi b/arch/arm64/boot/dts/broadcom/ns2.dtsi > > index 788ed8f..c77a9e8 100644 > > --- a/arch/arm64/boot/dts/broadcom/ns2.dtsi > > +++ b/arch/arm64/boot/dts/broadcom/ns2.dtsi > > @@ -357,6 +357,36 @@ > > status = "disabled"; > > }; > > > > + uart0: serial@66100000 { > > + compatible = "snps,dw-apb-uart"; > > + reg = <0x66100000 0x100>; > > + interrupts = ; > > + clocks = <&iprocslow>; > > + reg-shift = <2>; > > + reg-io-width = <4>; > > + status = "disabled"; > > + }; > > + > > + uart1: serial@66110000 { > > + compatible = "snps,dw-apb-uart"; > > + reg = <0x66110000 0x100>; > > + interrupts = ; > > + clocks = <&iprocslow>; > > + reg-shift = <2>; > > + reg-io-width = <4>; > > + status = "disabled"; > > + }; > > + > > + uart2: serial@66120000 { > > + compatible = "snps,dw-apb-uart"; > > + reg = <0x66120000 0x100>; > > + interrupts = ; > > + clocks = <&iprocslow>; > > + reg-shift = <2>; > > + reg-io-width = <4>; > > + status = "disabled"; > > + }; > > + > > uart3: serial@66130000 { > > compatible = "snps,dw-apb-uart"; > > reg = <0x66130000 0x100>; > > > >