From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752999AbcEMKKS (ORCPT ); Fri, 13 May 2016 06:10:18 -0400 Received: from regular1.263xmail.com ([211.150.99.140]:38443 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752831AbcEMKKP (ORCPT ); Fri, 13 May 2016 06:10:15 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: wulf@rock-chips.com X-FST-TO: gregkh@linuxfoundation.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: wulf@rock-chips.com X-UNIQUE-TAG: <5c3344b2a4165f8a8dbc27957f9399a6> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <5735A776.9050602@rock-chips.com> Date: Fri, 13 May 2016 18:07:50 +0800 From: William Wu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: gregkh@linuxfoundation.org, balbi@kernel.org, heiko@sntech.de CC: linux-rockchip@lists.infradead.org, briannorris@google.com, dianders@google.com, kever.yang@rock-chips.com, huangtao@rock-chips.com, frank.wang@rock-chips.com, eddie.cai@rock-chips.com, John.Youn@synopsys.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH] usb: dwc3: add DWC3_GUCTL1 reg for debug References: <1463133926-7366-1-git-send-email-william.wu@rock-chips.com> In-Reply-To: <1463133926-7366-1-git-send-email-william.wu@rock-chips.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/13/2016 06:05 PM, William Wu wrote: > GUCTL1 reg has some useful functions which can be > written by user. For rockchip platform, we set > GUCTL1.DEV_FORCE_20_CLK_FOR_30_CLK (bit26, applicable > for the core is programmed to operate in 2.0 device > only) to 1 in bootrom, and after start the kernel, > we want to check whether this bit can be reset to > default 0 after the core reset. Dump GUCTL1 reg from > debugfs is more convenient for us. > > Signed-off-by: William Wu > --- > Changes in v2: > - add commit log > > drivers/usb/dwc3/core.h | 1 + > drivers/usb/dwc3/debugfs.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h > index abed84f..c4758d5 100644 > --- a/drivers/usb/dwc3/core.h > +++ b/drivers/usb/dwc3/core.h > @@ -86,6 +86,7 @@ > #define DWC3_GCTL 0xc110 > #define DWC3_GEVTEN 0xc114 > #define DWC3_GSTS 0xc118 > +#define DWC3_GUCTL1 0xc11c > #define DWC3_GSNPSID 0xc120 > #define DWC3_GGPIO 0xc124 > #define DWC3_GUID 0xc128 > diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c > index b1dd3c6..f3c9f44 100644 > --- a/drivers/usb/dwc3/debugfs.c > +++ b/drivers/usb/dwc3/debugfs.c > @@ -47,6 +47,7 @@ static const struct debugfs_reg32 dwc3_regs[] = { > dump_register(GCTL), > dump_register(GEVTEN), > dump_register(GSTS), > + dump_register(GUCTL1), > dump_register(GSNPSID), > dump_register(GGPIO), > dump_register(GUID), I'm sorry for forgot to add v2 in commit. I'll resend it later.