From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932221AbcEMM1E (ORCPT ); Fri, 13 May 2016 08:27:04 -0400 Received: from eusmtp01.atmel.com ([212.144.249.242]:10115 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932067AbcEMM1B (ORCPT ); Fri, 13 May 2016 08:27:01 -0400 Subject: Re: [PATCH 1/3] dmaengine: at_xdmac: align descriptors on 64 bits To: Ludovic Desroches , References: <1463064854-6719-1-git-send-email-ludovic.desroches@atmel.com> CC: , , From: Nicolas Ferre Organization: atmel Message-ID: <5735C822.7000503@atmel.com> Date: Fri, 13 May 2016 14:27:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <1463064854-6719-1-git-send-email-ludovic.desroches@atmel.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 12/05/2016 16:54, Ludovic Desroches a écrit : > Having descriptors aligned on 64 bits allows update CNDA and CUBC in an > atomic way. > > Signed-off-by: Ludovic Desroches > Fixes: e1f7c9eee707 ("dmaengine: at_xdmac: creation of the atmel > eXtended DMA Controller driver") > Cc: stable@vger.kernel.org #v4.1 and later Reviewed-by: Nicolas Ferre > --- > drivers/dma/at_xdmac.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c > index 8e304b1..ba9b0b7 100644 > --- a/drivers/dma/at_xdmac.c > +++ b/drivers/dma/at_xdmac.c > @@ -242,7 +242,7 @@ struct at_xdmac_lld { > u32 mbr_dus; /* Destination Microblock Stride Register */ > }; > > - > +/* 64-bit alignment needed to update CNDA and CUBC registers in an atomic way. */ > struct at_xdmac_desc { > struct at_xdmac_lld lld; > enum dma_transfer_direction direction; > @@ -253,7 +253,7 @@ struct at_xdmac_desc { > unsigned int xfer_size; > struct list_head descs_list; > struct list_head xfer_node; > -}; > +} __aligned(sizeof(u64)); > > static inline void __iomem *at_xdmac_chan_reg_base(struct at_xdmac *atxdmac, unsigned int chan_nb) > { > -- Nicolas Ferre