From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753512AbcEMPia (ORCPT <rfc822;w@1wt.eu>);
	Fri, 13 May 2016 11:38:30 -0400
Received: from mout.gmx.net ([212.227.17.22]:53352 "EHLO mout.gmx.net"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752830AbcEMPi2 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 13 May 2016 11:38:28 -0400
Subject: Re: [PATCH] Input: pwm-beeper - defer pwm config if pwm can sleep
To: Thierry Reding <thierry.reding@gmail.com>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>
References: <56C4735E.6020300@gmx.at> <20160222194639.GD26177@dtor-ws>
 <20160512121852.GB26824@ulmo.ba.sec>
Cc: Manfred Schlaegl <manfred.schlaegl@ginzinger.com>,
        Luis de Bethencourt <luis@debethencourt.com>,
        Olivier Sobrie <olivier@sobrie.be>, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
From: Manfred Schlaegl <manfred.schlaegl@gmx.at>
Message-ID: <5735F4E3.20008@gmx.at>
Date: Fri, 13 May 2016 17:38:11 +0200
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101
 Icedove/38.7.0
MIME-Version: 1.0
In-Reply-To: <20160512121852.GB26824@ulmo.ba.sec>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:AsKT/CvzD2u0ENyagYQNMnSrqMsu2ZJgBRQ8DEmg1M/qa/jYhoa
 fR8j+jyKvDD+xz+ELdWiUfS3xC3aj3rKGpvddQi/5bTEg2RhFozLNPoHJDauvBE/YzQJqLU
 AMnj+0cMPaThyQEXxrsUPhxI9nsFV8Gd+GNbfOGbrNLgjxlj/NWgHi85j89fR1gp2D00Uuu
 ncH0ja5k19QT57QgEJ34A==
X-UI-Out-Filterresults: notjunk:1;V01:K0:bLDbJjSCWK8=:t/NlctU1+JPFtOx7hqvbzX
 lwfP6LrYGdP0vKY08bwWQ4lYGJTTguS0GZH4XPdbXDlriTxfLpQ8fP+LFgV9Bj5bYFOQbosbl
 6GlsWN2eSitcSRHEGfRrT97V4qRFQRuSMfO1mx+4Trb43jdkvtJ+/u2lyt8TSZtRu7RPC1Qh9
 MczEENHhnkZ9i3uxEzWfTwkpd/RuiaI32xmbwMEbU7Tq8zSe8jsi8iTbl9UXLVlBNhDsyehmS
 4dpGyGESKWDBUKIoG4LJ5hcSLWt195SjmhbcN0IzS6E3JCs8hvXbUGIOrFYXrwiZ+SAAlV7/b
 T7VHhNaIbh+whZung30NkrsWEzP4r7fOOc+v2XXdUhm8XKyWc/e0OB34uG/swOHUPKXKU3LF/
 TLo2Y9Vc205ROq/KTY4E5ZSFOTl55Cu+rhy9TXY/KPQuXk0Viv/SsE3elSg26eK4HCo5ahvFq
 FC+bpgguj2BHhNIWVjqGkMxPktdCmfXOhJ8wLYU3X5vLDNTz8jJ2GEHz5CDwvmuCs7yVu2tzx
 PrfROJQs21FL3dG3gMOqYD3XLx0DWWKNmKFVKVz4JVuPUjudJZJuVbFVZKWIgKnf+cCEw3rlJ
 q2MxLYlwO6T3MpfX6hIA42jTp1BkVa3OPoRvuYjkV6NqX7/Sw85B7JOGT3nbSGsgy/euU901P
 rloSMPM9mQcAsn5UTlHeoANQ10/N5RTjCXooUc7IxJjKonpKJPq6DZh1C4siZDXppOEm1vCQY
 nw59rtxp2REKhwhsaVtVn5t4tmZg2a/2lzdinP3k9Rx7FBRuB5LSSaqW52u3epSABKbJMy7Zx
 +FrRiR1
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2016-05-12 14:18, Thierry Reding wrote:
> 
> I agree with Dmitry. Users of the PWM API should always assume that
> calls to the PWM API might sleep. Conditionalizing on pwm_can_sleep()
> isn't a good idea, since that function is scheduled to be removed. In
> fact it's been returning true unconditionally since v4.5, so the fast
> path is dead code anyway.
> 

In this case, the decision is clear ;-)
I'll rework and send the new patch in the next days.

best regards,
manfred