From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932328AbcEMQHZ (ORCPT ); Fri, 13 May 2016 12:07:25 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:38192 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932300AbcEMQHW (ORCPT ); Fri, 13 May 2016 12:07:22 -0400 Subject: Re: [PATCH] i2c: Raise SDA for each received bit, if necessary To: Wolfram Sang References: <1461780714-20378-1-git-send-email-tdz@users.sourceforge.net> <20160512090544.GB1638@katana> <5734AD00.3050904@users.sourceforge.net> <20160513103355.GE1778@katana> Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org From: Thomas Zimmermann Message-ID: <5735FB9D.2060300@users.sourceforge.net> Date: Fri, 13 May 2016 18:06:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.7.0 MIME-Version: 1.0 In-Reply-To: <20160513103355.GE1778@katana> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Am 13.05.2016 um 12:33 schrieb Wolfram Sang: > >> I was playing with the DRM framework and an old SiS graphics card. I >> discovered this issue while trying to read the EDID from the monitor. > > So, there is no upstream user yet? No. >> I have a few other SiS cards/models here and they all expose this >> behavior. So I guess it's intentional(==cheaper?), although the HW docs >> don't seem mention it explicitly. > > OK. Well. As this flag is potentially dangerous, I would prefer to not > apply the patch unless there is an upstream user of this. If there is > one, I'd be okay with applying it with the flag renamed to something > like "dangerous_push_pull_bus" or similar with additional comments > saying there is some (broken) HW which needs it but nobody should get > the idea to design a bus like this. > > Makes sense? Sure, thanks! Best regards Thomas > Regards, > > Wolfram > -- GnuPG: http://tdz.users.sourceforge.net/tdz.asc Fingerprint: 16FF F599 82F8 E5AA 18C6 5220 D9DA D7D4 4EF1 DF08