From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932420AbcENUBK (ORCPT ); Sat, 14 May 2016 16:01:10 -0400 Received: from mail-bn1bon0078.outbound.protection.outlook.com ([157.56.111.78]:51232 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753790AbcENUBI (ORCPT ); Sat, 14 May 2016 16:01:08 -0400 Authentication-Results: oracle.com; dkim=none (message not signed) header.d=none;oracle.com; dmarc=none action=none header.from=amd.com; Subject: Re: [PATCH v2] drm/amd/powerplay: use ARRAY_SIZE() to calculate array size. To: Muhammad Falak R Wani , David Airlie References: <1463161029-7490-1-git-send-email-falakreyaz@gmail.com> CC: =?UTF-8?Q?Nils_Wallm=c3=a9nius?= , Jammy Zhou , , , Alex Deucher , Rex Zhu , =?UTF-8?Q?Christian_K=c3=b6nig?= , Dan Carpenter From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <573783E4.7040001@amd.com> Date: Sat, 14 May 2016 22:00:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <1463161029-7490-1-git-send-email-falakreyaz@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [2a02:908:1250:ae81:392a:c6ae:cb21:b4a5] X-ClientProxiedBy: HE1PR02CA0045.eurprd02.prod.outlook.com (10.163.170.13) To CY1PR12MB0136.namprd12.prod.outlook.com (10.161.173.18) X-MS-Office365-Filtering-Correlation-Id: 3ae926df-1a5f-406d-b3d3-08d37c327b66 X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0136;2:v/Endn+EluBd95T5tp0lbpWAgCv54oAamzGJgnTeVLa3G+1csI0MuOqeLE3/QDxmk9DYPoKck2yqgpayKm/XAoDdNQj82l+SzrOAyQw2Hv0Pm3cYgMF+T6kqclPRUwo7OS6H9pFx/nnPhYW9DgY88VFG1AdWriH3IgeOA9I1sIGMWatWZyi52uEM0ZrwKD59;3:Ul91hMn0RZ1MDWxQRAy962+Zal0e9IuM0lWN4NIQyTokTyGbirCcsL/XUHXV3Puxok8OXbmLCCn36MyRAx7lwaFiuVuRYDsmYo0vM3Af4vwW/ncj1Ztq08sVSJwYSVWq;25:y4TVkoq/zaarrPXNpq728lz8Ah1USJyDvM+CsMyKw9hEwG/dr/wiOsR+QNqqSLNEUFBrGkrWwo9PYqKIoMaQC9jXQdHcGWQPRfode1j39pZvGfZRQyUPnLZLm7Y/4Ifec6GimIhcMJBQNRN7cKo7F7cfVx+S/m+AORNdPdAcc6M5zaUR/jozEaErNvhS2Ig/njU5IzKfozojPn7TB2uYixnF6He2d2IG9wM+k9FkRfkR+DRPNOpXazz1Sowcv5bL8pc3JwFFNA1H5nrFxE/Ms7BhTRDyt5ULLTeD9nsQlujvO9atemmBXQZxvwrIgIULopIlOtSSCPcR1AKym/jBNdXT4umD/+j1JDYm6oF97LV+NZrFK1ZA9V1XGxVgy6Ssu2aKFrzYkbMrqsPK4e8JTvPWPALUdNbxVDIECLXByaY= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0136; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0136;20:jg1X4RX4NlWvQfeUaCj1KN+QLIolss4a42+i9UUpDLXZvw8q/jHFZkf/HS9NmhJjvcnVsznSlB9n/cshFNY7JeXhqq5xZ8VlY1vWNl7yaW0gzz3vX/BlmjcyXXah380LICpWgDHcYjO7/uAuYVJiuma6sB2oIVtUaqCCMv3n5HV3LiCL4YGRzWmjFxb/p8s/0gNZjSNo2wVrjgKKBYTe/POoU+7bmNDEIGOFw/csC7jk6WCgQxX4WW0VP1TCpJH3dmAFiF/JdPIk8g4WSSutmqHVH1hdE0EJEjIsKpfNq2MU9XQyvgxJL3OlHexF10pIf6Ns+a8CF1elKeG8vlCwDOVGkgb61jSpz5wQx7oE2jlFgpXXEBaBDQVR8zHCNjkcOqoGP2nY6JyzHnyIQgf3IifodJsba/h1CvdHmADY5g6NgkDt2dzvtr31fd0D9ahK0Gr0SUqUMA/XqZw9FlhL2n80gGQzItfJb/w/8xUcqRYFIMXDSobNp00Xe/ruafQM;4:Pstnh1AOudxZmMb3GPG20QbwwJ+JsxBOf+N7OxMQTdOsXmMj9FiziXeWaQHfZU7L+x0dmiDD9TepnckSb1oiIC0ePGhWqhiSZjyZqHpOVIhQjemnTsuqisIIJTcK0fX9Jofk6D3EPX9KcyjoconRIBZIZ1/TYMFJjXlgkZK57OAJjFflBSbR9Cz1SK+liPDR68n+o4D2JHTKIs0b407YZqgZLrxwSviwU507H2UUfMUDItGlJixl9hjrn1V3+hOIQKNVUetaVpNxKCNn68/8/RgfK6ZT3gCBkBD6cezWvmId3SXiZdLM4xijaPGu7Vy+ROLYIxjcAlOks6Y0tn5xXJpDrCCw/OHyZH5m0tRhMrklbrwwfVVTKFzhaglZmjjyY/qaYGwrKV6+//3+Frikbg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026);SRVR:CY1PR12MB0136;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0136; X-Forefront-PRVS: 094213BFEA X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(51914003)(42186005)(2906002)(586003)(5008740100001)(86362001)(2950100001)(189998001)(5004730100002)(64126003)(6116002)(65816999)(83506001)(2870700001)(50986999)(54356999)(76176999)(4326007)(36756003)(81166006)(33656002)(77096005)(65956001)(23676002)(50466002)(5001770100001)(8676002)(47776003)(99136001)(19580395003)(19580405001)(92566002)(65806001)(3826002);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR12MB0136;H:[IPv6:2a02:908:1250:ae81:392a:c6ae:cb21:b4a5];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjEyTUIwMTM2OzIzOnhNWFpRcVVYTnkvQjQwNHRUT25ZSVhia0V4?= =?utf-8?B?MjI2U1BMMXNTdHhZMk0zeUV0THV0QTY3TUxrNFRaNzVYTHl5MVJ2YmFHVHhT?= =?utf-8?B?VWV4YTRVYmRoVlJvejNXNU9tbUhMZnhCVDhYRHBYQ05UTWFWMTR6SzUrNWdI?= =?utf-8?B?amdqUWVYK0hzQkVNcldwbUVQY3RPaVRJMEFYdXdYcHhLeWgrTThZcUNvVkFQ?= =?utf-8?B?Q3pZZ1JCMlhvSUgxbkdJUnJ4QVVOK0lPNXM5NHlDUEhKakQwSjhCekE2MEx0?= =?utf-8?B?d3hndnFJYS8vcGV0WnluTHhTcStXUEYyc0VkcjQ0a3AweHk4aUlnblBmb3Mz?= =?utf-8?B?UnVoeks0YStqSVVkU05OK1NDell5Mzdyci9ld1F5NHJmMXpETXRCd1hLenk2?= =?utf-8?B?S1pRck8wem84U0NTb1JyZmdOLzdOdm9USUVVYW9Zcy9PdUVodU10NUp1QUZa?= =?utf-8?B?ajM4bkFWR1JaQWJnenBrelpuRysyQVpPNEZHS0MrZG9HWkJjWWMxVGZYVDNO?= =?utf-8?B?enNCTnF3dk1QSHpTOXIxK1dJVmNqNWNzVWg3VnZiTzRpYUc3OTdyb0daZGhC?= =?utf-8?B?WFI2U0wwc2syaUpaWHdKdE1Kem0zSXMzQnRHYmxMdXNISFpWUUdub3ppdzJx?= =?utf-8?B?V1VIQit5ZHJJKy9YZnVnaEFCWWdvTHVqRjAyNjVFTGx0YUY2OXlmSGJYWVZN?= =?utf-8?B?UVpPb0l5QWJrK0Nwa3BGcXdHQXQ5cm1oajhxZUdpcmRQb1RoOHNMKzZCMGow?= =?utf-8?B?MkRjNm15Y3JKYWs5TWo5SW1WQjZreXd2NFZqTUk1VXNmZXh3M1hROVNGVUVB?= =?utf-8?B?MWY1a25YZ2pnMjlTYzIvUDY0ZjhKRHI5RFRrRGowb2hZRkh6VzVxN3A4cEt6?= =?utf-8?B?eENjWlNtNFh3dGJ5SThhaENKTG5uU0xKVktpU3RqR2FnczVVaHFCUGwxNDZH?= =?utf-8?B?aTRzdWZUWlNDb3BDREZLMUJiSk5saVgyWnZVY2pDeEJLS0UxUURnb05Ca240?= =?utf-8?B?L0pTZGpqOXJpMjFRTUtpSmpKTFpxaThoblI1bjM0SSttMFZMTzRSK2x1RUty?= =?utf-8?B?U0h1RmVqdld4ZHJMWFpGT1Z1eEU3c29zVXRHRGlCbTV1UkQzK3pMTnA4Q0ZC?= =?utf-8?B?SHJkVDdPUmJDUk9OdjNJNnFNUTlFTnFXK2tqalVGNjBwSUo5MDRYVk5pUSti?= =?utf-8?B?aGFRSnFEU1FEZE9Kc29FR0QvTU5KV2xZZFQ2RmxkYjdadU5HNitsZTdZNDBO?= =?utf-8?B?MmVaZDVDWFBiU2hXSUltZzdVYnMwM1dETTJSb3NHNXZmdCtRMmtvZFQyL0tX?= =?utf-8?Q?u43yG2SvvyTgVoV2Ei9dRHbN7k6WEPew=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0136;5:aKeFr0yXb5wSFb/Pls8hIwSZaUVycdxefO7DDmmKoEkghpxNiKK5rQvtXE6ekal4Q/6S1nI+Z4OkB9PX/IztcP+395Ra9FHu2I9IRnZQ20h1KPsrw++iQSHUjNAa8UFgQnqlAVYmYRgJ9X+M5z/A3Q==;24:W+nT2oi7e6V7+RHF/F9ukYgqLsc3RBICRr7lUsyIthTA25uKJHnrF7Z4hCN700NlNWBFB9BgRqSAi8VGdAOtVWs7SwA2zxDyOSZqTDwUTNM=;7:UKEY67cMz5TliJuZw1Wi16B17vL9edS2OWu8cHyyf/nE+Q0YGnAlecTEdq8Js1JTHOj1rUUN1y3OKI2fz6G9p9h8TdDkp1AJdV/H9bsF8/3dRaKumBBk30XoDAfUsuOD7u92gNoZ7UvU7tuPh6kw/lf/ujrCgarxqRThZe0d0YA=;20:0KJtzDOGekl6cBRbexXLklf+9iVtVVXF9Td/9iHpPkZdr1AhTVsEIcjBL2wJTrZAsBTVe3/cRyaODZRpbGxj4HCvT2M1cOYWyWUv/vE6ZXbhRU6yi65/sLSXAescQ3dsZ+2Tk575vcNPTTqyGOYMvUCN0qogSy5bxJvfP8VrSoTSfccy5Y4A4JhBITOdRuFVDmdB5UoYhgKvqxS2Pr76/uG4SUDjk6xo7qo0Le78tNkEU2fOeS0trIjNI+3UVQrm X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2016 20:01:01.6471 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0136 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 13.05.2016 um 19:36 schrieb Muhammad Falak R Wani: > It is preferred to use ARRAY_SIZE() for size calculation, instead > using sizeof(array)/sizeof(*array). It makes the code more readable. > > Signed-off-by: Muhammad Falak R Wani Reviewed-by: Christian König Thanks for the cleanup, Christian. > --- > drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c > index da18f44..87c023e 100644 > --- a/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c > +++ b/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c > @@ -639,7 +639,7 @@ static int cz_smu_populate_firmware_entries(struct pp_smumgr *smumgr) > > cz_smu->driver_buffer_length = 0; > > - for (i = 0; i < sizeof(firmware_list)/sizeof(*firmware_list); i++) { > + for (i = 0; i < ARRAY_SIZE(firmware_list); i++) { > > firmware_type = cz_translate_firmware_enum_to_arg(smumgr, > firmware_list[i]);