From: Lu Baolu <baolu.lu@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: felipe.balbi@linux.intel.com,
Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Lee Jones <lee.jones@linaro.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 1/7] regulator: fixed: add support for ACPI interface
Date: Mon, 16 May 2016 09:00:18 +0800 [thread overview]
Message-ID: <57391BA2.70503@linux.intel.com> (raw)
In-Reply-To: <20160513111727.GD22038@sirena.org.uk>
Hi,
On 05/13/2016 07:17 PM, Mark Brown wrote:
> On Thu, May 05, 2016 at 01:32:57PM +0800, Lu Baolu wrote:
>
>> + gpiod = gpiod_get(dev, "gpio", GPIOD_ASIS);
>> + if (IS_ERR(gpiod))
>> + return ERR_PTR(-ENODEV);
>> + config->gpio = desc_to_gpio(gpiod);
>> + config->enable_high = device_property_read_bool(dev,
>> + "enable-active-high");
>> + gpiod_put(gpiod);
> This isn't going to work at all if the GPIO is shared between multiple
> regulators but I can't immediately see a sensible way to fix that
> without some surgery on the GPIO APIs so let's leave it for now.
Okay. Thanks.
Best regards,
Lu Baolu
next prev parent reply other threads:[~2016-05-16 1:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 5:32 [PATCH v8 0/7] usb: add support for Intel dual role port mux Lu Baolu
2016-05-05 5:32 ` [PATCH v8 1/7] regulator: fixed: add support for ACPI interface Lu Baolu
2016-05-13 11:17 ` Mark Brown
2016-05-16 1:00 ` Lu Baolu [this message]
2016-05-05 5:32 ` [PATCH v8 2/7] usb: mux: add generic code for dual role port mux Lu Baolu
2016-05-25 11:06 ` Heikki Krogerus
2016-05-26 1:03 ` Lu Baolu
2016-05-27 8:00 ` Heikki Krogerus
2016-05-27 8:07 ` Lu Baolu
2016-05-05 5:32 ` [PATCH v8 3/7] usb: mux: add driver for Intel gpio controlled " Lu Baolu
2016-05-05 5:33 ` [PATCH v8 4/7] usb: mux: add driver for Intel drcfg " Lu Baolu
2016-05-05 5:33 ` [PATCH v8 5/7] mfd: intel_vuport: Add Intel virtual USB port MFD Driver Lu Baolu
2016-05-09 14:26 ` Lee Jones
2016-05-05 5:33 ` [PATCH v8 6/7] usb: pci-quirks: add Intel USB drcfg mux device Lu Baolu
2016-05-05 5:33 ` [PATCH v8 7/7] MAINTAINERS: add maintainer entry for Intel USB dual role mux drivers Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57391BA2.70503@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=broonie@kernel.org \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox