From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752899AbcEPCIG (ORCPT <rfc822;w@1wt.eu>);
	Sun, 15 May 2016 22:08:06 -0400
Received: from szxga03-in.huawei.com ([119.145.14.66]:32679 "EHLO
	szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751342AbcEPCIE (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 15 May 2016 22:08:04 -0400
Subject: Re: [patch net-next 07/11] net: hns: dsaf adds support of acpi
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Yisen Zhuang <Yisen.Zhuang@huawei.com>, <davem@davemloft.net>,
        <rjw@rjwysocki.net>, <lenb@kernel.org>
References: <1463127557-90824-1-git-send-email-Yisen.Zhuang@huawei.com>
 <1463127557-90824-8-git-send-email-Yisen.Zhuang@huawei.com>
 <1463145136.17131.344.camel@linux.intel.com>
CC: <arnd@arndb.de>, <andrew@lunn.ch>, <geliangtang@163.com>,
        <ivecera@redhat.com>, <fengguang.wu@intel.com>,
        <charles.chenxin@huawei.com>, <haifeng.wei@huawei.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linuxarm@huawei.com>
From: "Yankejian (Hackim Yim)" <yankejian@huawei.com>
Message-ID: <57392B3C.2060609@huawei.com>
Date: Mon, 16 May 2016 10:06:52 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <1463145136.17131.344.camel@linux.intel.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.57.126.191]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A020201.57392B4B.008E,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-05-26 15:14:31,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: f0178442f5c1583a0b872b222a4a1187
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 2016/5/13 21:12, Andy Shevchenko wrote:
> On Fri, 2016-05-13 at 16:19 +0800, Yisen Zhuang wrote:
>> From: Kejian Yan <yankejian@huawei.com>
>>
>> Dsaf needs to get configuration parameter by ACPI, so this patch add
>> support of ACPI.
>>
> Looks like at some point better to split driver to core part, and PCI
> and ACPI/DT/platform code.
>
> Too many changes where IS_ENABLED() involved shows as I can imagine bad
> architecture / split of the driver.

Hi Andy,
Actully, we use the unified function asap. The routine in DT/ACPI maybe difference. Some routine
will be treated in BIOS in ACPI case, but it will be treated in OS in DT case, so we need to distinguish
it.
And we will try to reduce the use of IS_ENABLED().

Thanks very much for your suggestions, Andy

Kejian