From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751932AbcEPFjb (ORCPT ); Mon, 16 May 2016 01:39:31 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:42427 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750753AbcEPFja (ORCPT ); Mon, 16 May 2016 01:39:30 -0400 Subject: Re: [PATCH] ixgbe: take online CPU number as MQ max limit when alloc_etherdev_mq() To: Sergei Shtylyov , jeffrey.t.kirsher@intel.com, jesse.brandeburg@intel.com, shannon.nelson@intel.com, carolyn.wyborny@intel.com, donald.c.skidmore@intel.com, bruce.w.allan@intel.com, john.ronciak@intel.com, mitch.a.williams@intel.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org References: <1463118995-31763-1-git-send-email-ethan.zhao@oracle.com> Cc: linux-kernel@vger.kernel.org, ethan.kernel@gmail.com From: ethan zhao Organization: Oracle Corporation Message-ID: <57395CED.1090200@oracle.com> Date: Mon, 16 May 2016 13:38:53 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks for your reviewing. Ethan On 2016/5/13 20:52, Sergei Shtylyov wrote: > Hello. > > On 5/13/2016 8:56 AM, Ethan Zhao wrote: > >> Allocating 64 Tx/Rx as default doesn't benefit perfomrnace when less > > Performance. > >> CPUs were assigned. especially when DCB is enabled, so we should take >> num_online_cpus() as top limit, and aslo to make sure every TC has > > Also. > >> at least one queue, take the MAX_TRAFFIC_CLASS as bottom limit of queues >> number. >> >> Signed-off-by: Ethan Zhao >> --- >> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c >> b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c >> index 7df3fe2..1f9769c 100644 >> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c >> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c >> @@ -9105,6 +9105,10 @@ static int ixgbe_probe(struct pci_dev *pdev, >> const struct pci_device_id *ent) >> indices = IXGBE_MAX_RSS_INDICES; >> #endif >> } >> + /* Don't allocate too more queues than online cpus number */ > > "Too" not needed here. CPUs. > >> + indices = min_t(int, indices, num_online_cpus()); >> + /* To make sure TC works, allocate at least 1 queue per TC */ >> + indices = max_t(int, indices, MAX_TRAFFIC_CLASS); >> >> netdev = alloc_etherdev_mq(sizeof(struct ixgbe_adapter), indices); >> if (!netdev) { > > MBR, Sergei > >