From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753769AbcEPKCm (ORCPT ); Mon, 16 May 2016 06:02:42 -0400 Received: from smtp97.iad3a.emailsrvr.com ([173.203.187.97]:57818 "EHLO smtp97.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752500AbcEPKCl (ORCPT ); Mon, 16 May 2016 06:02:41 -0400 X-Auth-ID: abbotti@mev.co.uk X-Sender-Id: abbotti@mev.co.uk Subject: Re: [PATCH 2/4] Staging: comedi:Fix checkpatch issue in s626.c To: Ravishankar Karkala Mallikarjunayya , hsweeten@visionengravers.com, gregkh@linuxfoundation.org References: <1463036375-13527-1-git-send-email-ravishankarkm32@gmail.com> <1463036375-13527-2-git-send-email-ravishankarkm32@gmail.com> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Ian Abbott Message-ID: <57399ABE.5060707@mev.co.uk> Date: Mon, 16 May 2016 11:02:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 In-Reply-To: <1463036375-13527-2-git-send-email-ravishankarkm32@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/05/16 07:59, Ravishankar Karkala Mallikarjunayya wrote: > This is a patch to the s626.c file that fixes up a > WARNING: Prefer 'unsigned int' to bare use of 'unsigned' > found by the checkpatch.pl tool > > Signed-off-by: Ravishankar Karkala Mallikarjunayya > --- > drivers/staging/comedi/drivers/s626.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/s626.c b/drivers/staging/comedi/drivers/s626.c > index 43ab2e4..13f302d 100644 > --- a/drivers/staging/comedi/drivers/s626.c > +++ b/drivers/staging/comedi/drivers/s626.c > @@ -718,7 +718,7 @@ static uint16_t s626_get_mode_a(struct comedi_device *dev, > uint16_t cra; > uint16_t crb; > uint16_t setup; > - unsigned cntsrc, clkmult, clkpol, encmode; > + unsigned int cntsrc, clkmult, clkpol, encmode; > > /* Fetch CRA and CRB register images. */ > cra = s626_debi_read(dev, S626_LP_CRA(chan)); > @@ -773,7 +773,7 @@ static uint16_t s626_get_mode_b(struct comedi_device *dev, > uint16_t cra; > uint16_t crb; > uint16_t setup; > - unsigned cntsrc, clkmult, clkpol, encmode; > + unsigned int cntsrc, clkmult, clkpol, encmode; > > /* Fetch CRA and CRB register images. */ > cra = s626_debi_read(dev, S626_LP_CRA(chan)); > @@ -848,7 +848,7 @@ static void s626_set_mode_a(struct comedi_device *dev, > struct s626_private *devpriv = dev->private; > uint16_t cra; > uint16_t crb; > - unsigned cntsrc, clkmult, clkpol; > + unsigned int cntsrc, clkmult, clkpol; > > /* Initialize CRA and CRB images. */ > /* Preload trigger is passed through. */ > @@ -926,7 +926,7 @@ static void s626_set_mode_b(struct comedi_device *dev, > struct s626_private *devpriv = dev->private; > uint16_t cra; > uint16_t crb; > - unsigned cntsrc, clkmult, clkpol; > + unsigned int cntsrc, clkmult, clkpol; > > /* Initialize CRA and CRB images. */ > /* IndexSrc is passed through. */ > Thanks! Reviewed-by: Ian Abbott -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-