From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753640AbcEPKQm (ORCPT ); Mon, 16 May 2016 06:16:42 -0400 Received: from smtp129.dfw.emailsrvr.com ([67.192.241.129]:44496 "EHLO smtp129.dfw.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753323AbcEPKQk (ORCPT ); Mon, 16 May 2016 06:16:40 -0400 X-Auth-ID: abbotti@mev.co.uk X-Sender-Id: abbotti@mev.co.uk Subject: Re: [PATCH 3/4] Staging: comedi: fix type issue in s626.c To: Ravishankar Karkala Mallikarjunayya , hsweeten@visionengravers.com, gregkh@linuxfoundation.org References: <1463036375-13527-1-git-send-email-ravishankarkm32@gmail.com> <1463036375-13527-3-git-send-email-ravishankarkm32@gmail.com> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Ian Abbott Message-ID: <57399BF7.50105@mev.co.uk> Date: Mon, 16 May 2016 11:07:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 In-Reply-To: <1463036375-13527-3-git-send-email-ravishankarkm32@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/05/16 07:59, Ravishankar Karkala Mallikarjunayya wrote: > This is a patch to the s626.c file that fixes up a type issues > found by the checkpatch.pl tool. > > i.e Prefer kernel type 'u8' over 'uint8_t' > Prefer kernel type 'u16' over 'uint16_t' > Prefer kernel type 'u32' over 'uint32_t' > Prefer kernel type 's16' over 'int16_t' > Prefer kernel type 's32' over 'int32_t' > > Signed-off-by: Ravishankar Karkala Mallikarjunayya > --- > drivers/staging/comedi/drivers/s626.c | 150 +++++++++++++++++----------------- > 1 file changed, 75 insertions(+), 75 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/s626.c b/drivers/staging/comedi/drivers/s626.c > index 13f302d..fb27089 100644 > --- a/drivers/staging/comedi/drivers/s626.c > +++ b/drivers/staging/comedi/drivers/s626.c > @@ -75,7 +75,7 @@ struct s626_buffer_dma { > }; > > struct s626_private { > - uint8_t ai_cmd_running; /* ai_cmd is running */ > + u8 ai_cmd_running; /* ai_cmd is running */ > unsigned int ai_sample_timer; /* time between samples in > * units of the timer > */ > @@ -83,22 +83,22 @@ struct s626_private { > unsigned int ai_convert_timer; /* time between conversion in > * units of the timer > */ > - uint16_t counter_int_enabs; /* counter interrupt enable mask > + u16 counter_int_enabs; /* counter interrupt enable mask > * for MISC2 register > */ > - uint8_t adc_items; /* number of items in ADC poll list */ > + u8 adc_items; /* number of items in ADC poll list */ > struct s626_buffer_dma rps_buf; /* DMA buffer used to hold ADC (RPS1) > * program > */ > struct s626_buffer_dma ana_buf; /* DMA buffer used to receive ADC data > * and hold DAC data > */ > - uint32_t *dac_wbuf; /* pointer to logical adrs of DMA buffer > + u32 *dac_wbuf; /* pointer to logical adrs of DMA buffer > * used to hold DAC data > */ > - uint16_t dacpol; /* image of DAC polarity register */ > - uint8_t trim_setpoint[12]; /* images of TrimDAC setpoints */ > - uint32_t i2c_adrs; /* I2C device address for onboard EEPROM > + u16 dacpol; /* image of DAC polarity register */ > + u8 trim_setpoint[12]; /* images of TrimDAC setpoints */ > + u32 i2c_adrs; /* I2C device address for onboard EEPROM > * (board rev dependent) > */ > }; The patch is reasonable, but messes up the alignment of those comments, especially the multi-line comments. -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-