From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753359AbcEPKjB (ORCPT ); Mon, 16 May 2016 06:39:01 -0400 Received: from smtp97.iad3a.emailsrvr.com ([173.203.187.97]:43619 "EHLO smtp97.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750943AbcEPKjA (ORCPT ); Mon, 16 May 2016 06:39:00 -0400 X-Auth-ID: abbotti@mev.co.uk X-Sender-Id: abbotti@mev.co.uk Subject: Re: [PATCH 5/6] Staging: comedi: Fix WARNING issue in dt2801.c To: Ravishankar Karkala Mallikarjunayya , hsweeten@visionengravers.com, gregkh@linuxfoundation.org References: <1463393916-16243-1-git-send-email-ravishankarkm32@gmail.com> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Ian Abbott Message-ID: <5739A32C.6090905@mev.co.uk> Date: Mon, 16 May 2016 11:38:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 In-Reply-To: <1463393916-16243-1-git-send-email-ravishankarkm32@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/05/16 11:18, Ravishankar Karkala Mallikarjunayya wrote: > This is a patch to the dt2801.c file that fixes up a Block comments > issues found by the checkpatch.pl tool. > > i.e. Block comments use a trailing */ on a separate line > > Signed-off-by: Ravishankar Karkala Mallikarjunayya > --- > drivers/staging/comedi/drivers/dt2801.c | 84 ++++++++++++++++----------------- > 1 file changed, 42 insertions(+), 42 deletions(-) > Patch series should start at 1, not 5. In this case, your two patches PATCH 5/6 and PATCH 6/6 look independent from one another, and could be posted as individual patches, not in a series. > diff --git a/drivers/staging/comedi/drivers/dt2801.c b/drivers/staging/comedi/drivers/dt2801.c > index 6c7b4d2..51f2f75 100644 > --- a/drivers/staging/comedi/drivers/dt2801.c > +++ b/drivers/staging/comedi/drivers/dt2801.c > @@ -3,31 +3,30 @@ > * Device Driver for DataTranslation DT2801 > * > */ > -/* > -Driver: dt2801 > -Description: Data Translation DT2801 series and DT01-EZ > -Author: ds > -Status: works > -Devices: [Data Translation] DT2801 (dt2801), DT2801-A, DT2801/5716A, > - DT2805, DT2805/5716A, DT2808, DT2818, DT2809, DT01-EZ > - > -This driver can autoprobe the type of board. > - > -Configuration options: > - [0] - I/O port base address > - [1] - unused > - [2] - A/D reference 0=differential, 1=single-ended > - [3] - A/D range > - 0 = [-10, 10] > - 1 = [0,10] > - [4] - D/A 0 range > - 0 = [-10, 10] > - 1 = [-5,5] > - 2 = [-2.5,2.5] > - 3 = [0,10] > - 4 = [0,5] > - [5] - D/A 1 range (same choices) > -*/ > + /* Driver: dt2801 > + * Description: Data Translation DT2801 series and DT01-EZ > + * Author: ds > + * Status: works > + * Devices: [Data Translation] DT2801 (dt2801), DT2801-A, DT2801/5716A, > + * DT2805, DT2805/5716A, DT2808, DT2818, DT2809, DT01-EZ > + > + * This driver can autoprobe the type of board. > + > + * Configuration options: > + * [0] - I/O port base address > + * [1] - unused > + * [2] - A/D reference 0=differential, 1=single-ended > + * [3] - A/D range > + * 0 = [-10, 10] > + * 1 = [0,10] > + * [4] - D/A 0 range > + * 0 = [-10, 10] > + * 1 = [-5,5] > + * 2 = [-2.5,2.5] > + * 3 = [0,10] > + * 4 = [0,5] > + * [5] - D/A 1 range (same choices) > + */ Our usual block comment style is: /* * blah blah * blah blah */ i.e. the opening '/*' is on a line by itself. If you could fix up the block comments to conform to that style, that would be great! -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-