From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753434AbcEPKrQ (ORCPT ); Mon, 16 May 2016 06:47:16 -0400 Received: from smtp137.dfw.emailsrvr.com ([67.192.241.137]:55390 "EHLO smtp137.dfw.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751895AbcEPKrP (ORCPT ); Mon, 16 May 2016 06:47:15 -0400 X-Auth-ID: abbotti@mev.co.uk X-Sender-Id: abbotti@mev.co.uk Subject: Re: [PATCH 6/6] Staging: comedi: Fix CHECK:Avoid CamelCase issue in daqboard2000.c To: Ravishankar Karkala Mallikarjunayya , hsweeten@visionengravers.com, gregkh@linuxfoundation.org References: <1463393916-16243-1-git-send-email-ravishankarkm32@gmail.com> <1463393916-16243-2-git-send-email-ravishankarkm32@gmail.com> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Ian Abbott Message-ID: <5739A52C.8090704@mev.co.uk> Date: Mon, 16 May 2016 11:47:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 In-Reply-To: <1463393916-16243-2-git-send-email-ravishankarkm32@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/05/16 11:18, Ravishankar Karkala Mallikarjunayya wrote: > This is a patch to the daqboard2000.c file that fixes up a > issues found by the checkpatch.pl tool. > > Signed-off-by: Ravishankar Karkala Mallikarjunayya > --- > drivers/staging/comedi/drivers/daqboard2000.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/daqboard2000.c b/drivers/staging/comedi/drivers/daqboard2000.c > index a536a15..edd91a1 100644 > --- a/drivers/staging/comedi/drivers/daqboard2000.c > +++ b/drivers/staging/comedi/drivers/daqboard2000.c > @@ -116,12 +116,12 @@ > #define DAQBOARD2000_SUBSYSTEM_IDS4 0x0004 /* Daqboard/2000 - 4 Dacs */ > > /* Initialization bits for the Serial EEPROM Control Register */ > -#define DAQBOARD2000_SECRProgPinHi 0x8001767e > -#define DAQBOARD2000_SECRProgPinLo 0x8000767e > -#define DAQBOARD2000_SECRLocalBusHi 0xc000767e > -#define DAQBOARD2000_SECRLocalBusLo 0x8000767e > -#define DAQBOARD2000_SECRReloadHi 0xa000767e > -#define DAQBOARD2000_SECRReloadLo 0x8000767e > +#define DAQBOARD2000_SECRPROGPINHI 0x8001767e > +#define DAQBOARD2000_SECRPROGPINLO 0x8000767e > +#define DAQBOARD2000_SECRLOCALBUSHI 0xc000767e > +#define DAQBOARD2000_SECRLOCALBUSLO 0x8000767e > +#define DAQBOARD2000_SECRRELOADHI 0xa000767e > +#define DAQBOARD2000_SECRRELOADLO 0x8000767e > > /* SECR status bits */ > #define DAQBOARD2000_EEPROM_PRESENT 0x10000000 > This doesn't compile. Also, there are several other CamelCase issues in this driver, although probably too many to deal with in a single patch. I'll have a shot at a slightly more extensive clean-up. -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-