From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753809AbcEPOcP (ORCPT <rfc822;w@1wt.eu>);
	Mon, 16 May 2016 10:32:15 -0400
Received: from mailout4.w1.samsung.com ([210.118.77.14]:42455 "EHLO
	mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751754AbcEPOcN (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 16 May 2016 10:32:13 -0400
X-AuditID: cbfec7f5-f792a6d000001302-cb-5739d9ea9bf0
Message-id: <5739D9E9.6060801@samsung.com>
Date: Mon, 16 May 2016 16:32:09 +0200
From: Jacek Anaszewski <j.anaszewski@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804
 Thunderbird/17.0.8
MIME-version: 1.0
To: Tony Makkiel <tony.makkiel@daqri.com>
Cc: Linux LED Subsystem <linux-leds@vger.kernel.org>,
        Stas Sergeev <stsp@users.sourceforge.net>, Pavel Machek <pavel@ucw.cz>,
        lkml <linux-kernel@vger.kernel.org>
Subject: Re: Brightness control irrespective of blink state.
References: <1461881020-13964-1-git-send-email-ezequiel@vanguardiasur.com.ar>
 <1461881020-13964-2-git-send-email-ezequiel@vanguardiasur.com.ar>
 <57230B26.9010300@samsung.com> <572C5DEE.3070307@samsung.com>
 <CAAEAJfD_U1Z=wXQbK+DNdhZj5KEDkd3sK8mbBLNOvtKbZd1zYg@mail.gmail.com>
 <572CE1B0.8040001@daqri.com> <572CE715.6060504@gmail.com>
 <57309039.3060305@daqri.com> <5730A293.9050209@samsung.com>
 <5731ABB6.10607@daqri.com> <5731E194.1010004@samsung.com>
 <57321299.8090603@daqri.com> <5732FE64.6000907@samsung.com>
 <573336D9.7040105@daqri.com> <57345A59.5010607@samsung.com>
 <5735E2BD.4070405@daqri.com> <57399129.3020602@samsung.com>
 <5739CE75.80608@daqri.com> <5739D7CC.4040205@samsung.com>
In-reply-to: <5739D7CC.4040205@samsung.com>
Content-type: text/plain; charset=UTF-8; format=flowed
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrHLMWRmVeSWpSXmKPExsVy+t/xy7qvblqGG3y/o2lxedccNoutb9Yx
	Wtw9dZTNorNvGovF1AXTGR1YPfb8X8bqsWL1d3aPplPtrB6fN8kFsERx2aSk5mSWpRbp2yVw
	ZTzp+cdecJS1ovHKa5YGxn0sXYycHBICJhKv+zczQ9hiEhfurWfrYuTiEBJYyijxeHovM4Tz
	jFHi8tGDbCBVvAJaEouP/2LqYuTgYBFQlbj+1RIkzCZgKPHzxWsmEFtUIELiz+l9rBDlghI/
	Jt8DWyYioClxqK2REWQmM8iCbZO6GEESwgI2EnsXf2SHWHaEVeJvywawZZwC2hI7F04Hm8Qs
	YCbxqGUdM4QtL7F5zVvmCYwCs5AsmYWkbBaSsgWMzKsYRVNLkwuKk9JzjfSKE3OLS/PS9ZLz
	czcxQkL56w7GpcesDjEKcDAq8fAKfLMIF2JNLCuuzD3EKMHBrCTC63XOMlyINyWxsiq1KD++
	qDQntfgQozQHi5I478xd70OEBNITS1KzU1MLUotgskwcnFINjPMPsqyqXb13pmOmVvmqkzG5
	kgy+lgz6KnKlXCuEpovfzjTq3flf6PHRz3O88n/G6ybFKXxIVShnCP7+LYYtc3a7g2FPpIzm
	GS7d0zGCu2X7q3isz9/cHzbFT8h32xSDfe86H4v+qDm+s/lHkxD/bb57DYtcvFma3EM31kur
	br7/IsT62+mDSizFGYmGWsxFxYkAMarOOmECAAA=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/16/2016 04:23 PM, Jacek Anaszewski wrote:
> On 05/16/2016 03:43 PM, Tony Makkiel wrote:
if (led_cdev->flags & LED_BLINK_SW) .
>>>
>>> LED_BLINK_SW flag would have to be cleared in led_stop_software_blink()
>>> and in the first two conditions in the led_timer_function().
>>>
>>
>> Yes, that will do with minimal changes. I tested the following, and
>> works.
>
> Fine, so could you please submit the patch officially?
> Before that, please rebase your code on top of LED tree or linux-next
> and change LED_BLINKING_SW to LED_BLINK_SW, to keep the same prefix for
> each blinking related definition.

Also please put it before LED_BLINK_ONESHOT.

-- 
Best regards,
Jacek Anaszewski